fix: remove duplicate method from disbursement

[Nihantra-Patel]

Summary by CodeRabbit

• Bug Fixes

  • Loan disbursement now accepts decimal amount values for precise calculations

• Refactor

  • Removed unused validation logic from loan product configuration

[coderabbitai]

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 001d9175-e6ba-4088-b9fd-2d8ba86d9a1b

📥 Commits

Reviewing files that changed from the base of the PR and between 78453ff and 0004b13.

📒 Files selected for processing (2)

• lending/loan_management/doctype/loan/loan.py
• lending/loan_management/doctype/loan_product/loan_product.py

---

Walkthrough

This PR contains two targeted updates to the loan management doctypes. The make_loan_disbursement function signature is modified to accept float instead of int for the disbursement_amount parameter, with the default value changed from 0 to None. Separately, the validate_demand_offset_sequences method is removed from the LoanProduct class, while the module-level get_default_charge_accounts utility function remains in place.

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}