Edit cmake

[charliehuang09]

No description provided.

[Copilot]

Pull request overview

Refactors the project’s CMake build definitions to use target_sources() and to decompose previously monolithic libraries (notably camera and localization) into smaller component targets, alongside some CMake policy/build invocation updates.

Changes:

• Restructures utils and pathing CMake targets to use add_library(<name>) + target_sources().
• Splits camera and localization into multiple component libraries and introduces an aggregate camera interface target.
• Updates CMake policy handling and raises the CMake minimum required version in src/.

Reviewed changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 8 comments.

Show a summary per file

File	Description
src/utils/CMakeLists.txt	Converts utils to target_sources() style and reformats link dependencies.
src/pathing/CMakeLists.txt	Converts pathing to target_sources() style and changes its link dependencies.
src/localization/CMakeLists.txt	Splits localization into multiple component libraries and rewires linking.
src/camera/CMakeLists.txt	Splits camera into component libraries and introduces an aggregate camera interface target.
src/calibration/CMakeLists.txt	Refactors calibration executables’ CMake definitions (with some redundancy introduced).
src/CMakeLists.txt	Raises cmake_minimum_required for the src subdir and adjusts executable link lists.
CMakeLists.txt	Adds policy guards and FetchContent extract-timestamp setting.
scripts/build.sh	Adds -Wno-dev to the CMake configure invocation.

Comments suppressed due to low confidence (4)

src/localization/CMakeLists.txt:18

• OpencvApriltagDetector directly uses OpenCV APIs, but the target links only utils. This can produce link failures when OpenCV isn't already on the final link line. Link this target against OpenCV (prefer imported targets if available, otherwise ${OpenCV_LIBS}) so its dependency is explicit.

add_library(OpencvApriltagDetector)
target_sources(OpencvApriltagDetector
  PRIVATE
    opencv_apriltag_detector.cc
)
target_link_libraries(OpencvApriltagDetector PRIVATE
  utils
)

src/localization/CMakeLists.txt:27

• NvidiaApriltagDetector includes and uses OpenCV types/functions (and OpenCV-VPI interop), but the target links only utils. To avoid unresolved OpenCV symbols, add the required OpenCV link dependency (prefer imported targets if available, otherwise ${OpenCV_LIBS}) to this target.

add_library(NvidiaApriltagDetector)
target_sources(NvidiaApriltagDetector
  PRIVATE
    nvidia_apriltag_detector.cc
)
target_link_libraries(NvidiaApriltagDetector PRIVATE
  utils
)

src/calibration/CMakeLists.txt:17

• frame_shower sources are specified twice (in add_executable(frame_shower frame_shower.cc) and again in target_sources(frame_shower ...)). This is redundant; keep the source list in one place to avoid confusion.

add_executable(frame_shower frame_shower.cc)
target_sources(frame_shower
  PRIVATE
  frame_shower.cc
)

src/calibration/CMakeLists.txt:28

• focus_calibrate sources are specified twice (in add_executable(focus_calibrate focus_calibrate.cc) and again in target_sources(focus_calibrate ...)). This is redundant; keep the source list in one place to avoid confusion.

add_executable(focus_calibrate focus_calibrate.cc)
target_sources(focus_calibrate
  PRIVATE
  focus_calibrate.cc
)