Skip to content

fix mobile hamburger menu #302

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
zachwaffle4 merged 1 commit into from
Sep 17, 2026
+12 −49
Merged

fix mobile hamburger menu #302

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 10 additions & 45 deletions src/starlightOverrides/Header.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,7 @@ const { hasSidebar } = Astro.locals.starlightRoute;
type="button"
class="mobile-menu-toggle"
aria-label="Toggle navigation menu"
aria-expanded="false"
aria-controls="starlight__sidebar"
data-mobile-menu-toggle
popovertarget="starlight__sidebar"
>
<span class="hamburger-line" />
<span class="hamburger-line" />
Expand Down Expand Up @@ -169,45 +167,6 @@ const { hasSidebar } = Astro.locals.starlightRoute;
})();
</script>

<script is:inline>
(() => {
const initMobileMenuToggle = () => {
const toggle = document.querySelector('[data-mobile-menu-toggle]');
const nativeButton = document.querySelector(
'starlight-menu-button',
);
const nativeInnerButton = nativeButton?.querySelector('button');

if (!toggle || !nativeButton || !nativeInnerButton) return;

toggle.addEventListener('click', () => nativeInnerButton.click());

const syncExpanded = () => {
toggle.setAttribute(
'aria-expanded',
nativeButton.getAttribute('aria-expanded') || 'false',
);
};

syncExpanded();
new MutationObserver(syncExpanded).observe(nativeButton, {
attributes: true,
attributeFilter: ['aria-expanded'],
});
};

if (
document.readyState === 'complete' ||
document.readyState === 'interactive'
) {
initMobileMenuToggle();
} else {
document.addEventListener('DOMContentLoaded', initMobileMenuToggle);
}
document.addEventListener('astro:page-load', initMobileMenuToggle);
})();
</script>

<script is:inline>
(() => {
const storageKey = 'starlight-theme';
Expand Down Expand Up @@ -502,18 +461,24 @@ const { hasSidebar } = Astro.locals.starlightRoute;
bottom: 11px;
}

.mobile-menu-toggle[aria-expanded='true'] .hamburger-line:nth-child(1) {
:global(body:has(#starlight__sidebar:popover-open))
.mobile-menu-toggle
.hamburger-line:nth-child(1) {
top: 50%;
margin-top: -1.5px;
transform: rotate(45deg);
}

.mobile-menu-toggle[aria-expanded='true'] .hamburger-line:nth-child(2) {
:global(body:has(#starlight__sidebar:popover-open))
.mobile-menu-toggle
.hamburger-line:nth-child(2) {
opacity: 0;
transform: scale(0);
}

.mobile-menu-toggle[aria-expanded='true'] .hamburger-line:nth-child(3) {
:global(body:has(#starlight__sidebar:popover-open))
.mobile-menu-toggle
.hamburger-line:nth-child(3) {
bottom: auto;
top: 50%;
margin-top: -1.5px;
Expand Down
6 changes: 2 additions & 4 deletions src/styles/global.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,10 +73,8 @@ body {
overscroll-behavior-y: none;
}

@media (max-width: 50rem) {
starlight-menu-button {
display: none !important;
}
.sl-menu-button {
display: none !important;
}

/* ==========================================================================
Expand Down
Loading