Set cmake policy CMP0177 in CMakeLists.txt to resolve cmake warning.#83
Closed
dpsproservices wants to merge 1 commit intofree-audio:mainfrom
Closed
Set cmake policy CMP0177 in CMakeLists.txt to resolve cmake warning.#83dpsproservices wants to merge 1 commit intofree-audio:mainfrom
dpsproservices wants to merge 1 commit intofree-audio:mainfrom
Conversation
resolve cmake v 3.31 warning expecting install policy CMP0177 to be set
Contributor
|
LGTM, @baconpaul do you approve as well? |
abique
approved these changes
May 4, 2025
Collaborator
|
We have install rules which contain a . But I’ve never used them. Do we know if anyone does use them? And if they work as designed with NEW? That’s my primary question. Fine to merge if we can answer that. But if we can’t we could also remove the install rules and the policy set I think |
Contributor
|
So you only get the warning if the normalization would produce a different path. I'd just go with cmake's new behavior, because I don't feel like maintaining an "old" behavior here. |
Collaborator
|
Yeah that's fine! My only question is does it actually work with new? We may also need to bump the cmake min version to get the CMP in place. Or condition the CMP on cmake version. |
Merged
Collaborator
|
This is addressed another way in #87 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change to CMakeLists.txt is intended to resolve a cmake warning regarding cmake install policy CMP0177 which was introduced in cmake v 3.31.
The install policy is expected to be set to either OLD or NEW.
cmake_policy(SET CMP0177 NEW)I referred to the information about CMP0177 on the cmake site here: CMP0177