Skip to content

Set cmake policy CMP0177 in CMakeLists.txt to resolve cmake warning.#83

Closed
dpsproservices wants to merge 1 commit intofree-audio:mainfrom
dpsproservices:main
Closed

Set cmake policy CMP0177 in CMakeLists.txt to resolve cmake warning.#83
dpsproservices wants to merge 1 commit intofree-audio:mainfrom
dpsproservices:main

Conversation

@dpsproservices
Copy link
Copy Markdown

This change to CMakeLists.txt is intended to resolve a cmake warning regarding cmake install policy CMP0177 which was introduced in cmake v 3.31.

The install policy is expected to be set to either OLD or NEW.

cmake_policy(SET CMP0177 NEW)

I referred to the information about CMP0177 on the cmake site here: CMP0177

resolve cmake v 3.31 warning expecting install policy CMP0177 to be set
@CLAassistant
Copy link
Copy Markdown

CLAassistant commented May 3, 2025

CLA assistant check
All committers have signed the CLA.

@abique
Copy link
Copy Markdown
Contributor

abique commented May 4, 2025

LGTM, @baconpaul do you approve as well?

@abique abique requested review from abique and baconpaul May 4, 2025 09:48
@baconpaul
Copy link
Copy Markdown
Collaborator

We have install rules which contain a . But I’ve never used them. Do we know if anyone does use them? And if they work as designed with NEW? That’s my primary question.

Fine to merge if we can answer that. But if we can’t we could also remove the install rules and the policy set I think

@abique
Copy link
Copy Markdown
Contributor

abique commented May 4, 2025

So you only get the warning if the normalization would produce a different path.

I'd just go with cmake's new behavior, because I don't feel like maintaining an "old" behavior here.

@baconpaul
Copy link
Copy Markdown
Collaborator

Yeah that's fine! My only question is does it actually work with new?

We may also need to bump the cmake min version to get the CMP in place. Or condition the CMP on cmake version.

@mthierman mthierman mentioned this pull request Sep 28, 2025
@baconpaul
Copy link
Copy Markdown
Collaborator

This is addressed another way in #87

@baconpaul baconpaul closed this Sep 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants