Add base implementation of surround extension#84
Merged
abique merged 4 commits intofree-audio:nextfrom Jul 8, 2025
Merged
Conversation
abique
reviewed
Jul 8, 2025
abique
reviewed
Jul 8, 2025
free-audio#84#discussion_r2192490266
free-audio#84#discussion_r2192491651
Contributor
|
LGTM |
abique
pushed a commit
that referenced
this pull request
Nov 28, 2025
abique
pushed a commit
that referenced
this pull request
Nov 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds the surround extension to the clap-helpers so that consumers of the clap-helpers can implement it into their plugins. It also adds some minimal level checks to the base implementation.
The plugin functions
is_channel_mask_supportedandget_channel_mapensure they're called when the plugin is not active due to the surround extension's comment (seeIf the host decides to change the project's surround setupandIf the plugin wants to change its surround setup) using them only after the plugin has been deactivated.