Skip to content

Add webview extension#86

Merged
abique merged 2 commits intofree-audio:nextfrom
Trinitou:webview-extension
Nov 28, 2025
Merged

Add webview extension#86
abique merged 2 commits intofree-audio:nextfrom
Trinitou:webview-extension

Conversation

@Trinitou
Copy link
Copy Markdown
Contributor

No description provided.

@geraintluff
Copy link
Copy Markdown
Contributor

geraintluff commented Jul 29, 2025

Looks sensible to me.

Not sure why that check failed. It can't find the CLAP_EXT_WEBVIEW constant - does it know to point at clap:next? I guess this is blocked until (hopefully) CLAP 1.2.7 anyway.

@Trinitou
Copy link
Copy Markdown
Contributor Author

Trinitou commented Jul 29, 2025

Looks sensible to me.

Not sure why that check failed. It can't find the CLAP_EXT_WEBVIEW constant - does it know to point at clap:next? I guess this is blocked until (hopefully) CLAP 1.2.7 anyway.

I think it's because the github workflow chose the path where it takes the clap main branch (where CLAP_EXT_WEBVIEW isn't known yet). @baconpaul put some logic in place so that the clap next branch is chosen in some cases. In the log you see that it chose Configure (not next).

The 1.2.7 is why I did this as draft for now 🤷‍♂️

@geraintluff
Copy link
Copy Markdown
Contributor

geraintluff commented Nov 27, 2025

Bumping because 1.2.7 is out, but it's not urgent. I'm not personally using these helpers, but it'd be nice to encourage people who are.

The merged draft extension has a get_resource() method which isn't reflected here.

@abique abique marked this pull request as ready for review November 28, 2025 07:48
@abique
Copy link
Copy Markdown
Contributor

abique commented Nov 28, 2025

I'm not sure how to relaunch the tests.

@abique abique merged commit 23a80d0 into free-audio:next Nov 28, 2025
1 of 13 checks passed
@Trinitou Trinitou deleted the webview-extension branch November 28, 2025 08:00
@Trinitou
Copy link
Copy Markdown
Contributor Author

@abique unfortunately this PR was based on an older version of the webview draft extension which is missing the get_resource method (+maybe other changes?)

@abique
Copy link
Copy Markdown
Contributor

abique commented Nov 28, 2025

I've done the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants