fix(#486): connect to SAE-only WPA3-Personal networks - #535
Merged
Merged
Conversation
WpaPsk emits key-mgmt=wpa-psk, which NetworkManager rejects on APs advertising SAE without PSK. Add WifiSecurity::Sae and WifiConnectionBuilder::sae(), and upgrade WpaPsk to Sae in connect() when the target AP is SAE-only. Transition-mode APs still accept PSK and are left alone.
cachebag
added
bug
cachebag
had a problem deploying
to
self-hosted-pr-integration
September 2, 2026 17:57 — with 
GitHub Actions
Failure
GitHub Actions
Failure
cachebag
force-pushed
the
bugfix/support-sae
branch
from
September 2, 2026 18:08
a46d59c to
25c4269
Compare
cachebag
had a problem deploying
to
self-hosted-pr-integration
September 2, 2026 18:08 — with
GitHub Actions
Failure
GitHub Actions
Failure
Add a second SAE-only BSS to the hwsim AP radio with its own subnet and dnsmasq. The test asserts the AP is SAE-only, then that a WpaPsk connect succeeds and stores a WifiKeyMgmt::Sae profile.
cachebag
force-pushed
the
bugfix/support-sae
branch
from
September 2, 2026 18:13
25c4269 to
3dda971
Compare
cachebag
deployed
to
self-hosted-pr-integration
September 2, 2026 18:13 — with
GitHub Actions
Active
GitHub Actions
Active
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Connecting to a WPA3-only network with
WifiSecurity::WpaPskfails. We always sendkey-mgmt=wpa-psk, and NetworkManager rejects that if the AP only does SAE. Reported from COSMIC Settings.This adds
WifiSecurity::SaeandWifiConnectionBuilder::sae(). On top of that,connect()now checks the AP's security flags: if the AP is SAE-only and the caller passedWpaPsk, we sendsaeinstead. APs that support both are left alone sincewpa-pskstill works there.Also adds an integration test. The hwsim harness now runs a second, SAE-only AP so the test can actually hit the failing case. I could not run the harness locally, so CI will be the first real run of that config. It needs a hostapd built with SAE.
Fixes #486
Fixes downstream related pop-os/cosmic-settings#2068