feat(#540): expose NetworkManager global DNS configuration - #549
Merged
cachebag merged 2 commits intoSep 8, 2026
Merged
Conversation
cachebag
added
feature
sage-s11
deployed
to
self-hosted-pr-integration
September 8, 2026 16:19 — with 
GitHub Actions
Active
GitHub Actions
Active
Member
Can you not install Docker? I'm not sure why you included this part since the contribution guide states you should attempt to run these locally. I only bring this up since the harness runs on my self-hosted runner and I prefer not doing that for new contributors (at least until, some sort of validation has been made on their end of course and/or the PR is approved on my end). |
This comment was marked as low quality.
This comment was marked as low quality.
cachebag
requested changes
Sep 8, 2026
…docs Move the changelog entry under Added, document public fields, add GlobalDnsConfiguration::validate() for the default-domain and servers rules, and note conf/polkit write failures.
sage-s11
had a problem deploying
to
self-hosted-pr-integration
September 8, 2026 19:18 — with
GitHub Actions
Failure
GitHub Actions
Failure
sage-s11
had a problem deploying
to
self-hosted-pr-integration
September 8, 2026 19:26 — with
GitHub Actions
Failure
GitHub Actions
Failure
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GlobalDnsConfigurationon/org/freedesktop/NetworkManagerGlobalDnsConfiguration/GlobalDnsDomain(searches,options,domains["*"].servers)NetworkManager::global_dns_configuration()/set_global_dns_configuration()Closes #540
Validation
cargo fmt --all -- --checkcargo clippy --all-targets --all-features -- -D warningscargo test -p nmrs --lib --all-featurescargo test --doc --all-features --workspacecargo test --all-features --workspacegit diff --checkDocker integration was not run locally (Docker is not installed). The ignored
networkmanager_global_dns_configuration_round_triptest is in the existing harness for CI.AI assistance
Used Copilot to understand project structure, locate dependencies/concerned functions, modify docs, debug compilation errors and write PR description. I reviewed the diff and ran the validation above.