Skip to content

Update dependency joi to v18.2.5 [SECURITY] - #2440

Open
renovate[bot] wants to merge 1 commit into
mainfrom
renovate/npm-joi-vulnerability
Open

renovate[bot] wants to merge 1 commit into
mainfrom
renovate/npm-joi-vulnerability

Conversation

@renovate

@renovate renovate Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

This PR contains the following updates:

Package Change Age Confidence
joi 18.2.318.2.5 age confidence

joi: object().rename() with a template target can set the validated object's prototype

CVE-2026-84367 / GHSA-gg4h-3hg2-grpc

More information

Details

Impact

Applications are affected only if a schema renames keys with a regular-expression source and a Joi.expression() / Joi.x() target that interpolates the pattern's own match data, combined with { multiple: true }, for example .rename(/^x-(.+)$/, Joi.x('{#​1}'), { multiple: true }). Because the target is rendered from the matched input key, an attacker who controls input keys can send x-__proto__ with an object value and make the rename target render as __proto__, which sets the prototype of the object joi returns instead of creating a key on it. The global Object.prototype is not modified, so the effect is confined to the object returned by that one validate() call.

Schemas using a static string rename target are not affected, and neither are schemas left on the default { multiple: false }.

Patches

Versions 17.13.5 and 18.2.4 have been released to address the issue.

Workarounds
  1. Replace the template rename target with a static string target.
  2. Keep the template but make the capture unable to produce __proto__, using a negative lookahead: .rename(/^x-(?!__proto__$)(.+)$/, Joi.x('{#​1}'), { multiple: true })
  3. Drop { multiple: true } from the rename, which stops the rename before the assignment.

Severity

  • CVSS Score: 3.7 / 10 (Low)
  • Vector String: CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:L/A:N

References

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).


joi: Prototype pollution via a __proto__ language key in custom messages

CVE-2026-84368 / GHSA-6w3j-5fw6-r9vr

More information

Details

Impact

An application that passes attacker-controlled data into joi's custom message configuration (messages(), message(), prefs({ messages }), Joi.extend({ messages }) or rule({ message })) lets the attacker write properties onto Object.prototype, where every object in the process then inherits them. A key named __proto__ was treated as a language name, and the code reused the object it found at that key, which resolves to the prototype rather than to a new own property; a key named constructor did the same to the Object function's statics. A consuming application that gates on the mere presence of a property (if (user.isAdmin)) can be made to take the wrong branch for every object it inspects.

This is not reachable from data that joi validates. Custom messages are schema-construction configuration, normally written by the application developer. Exploitation therefore requires an application that feeds untrusted input straight into schema construction.

Patches

Upgrade to version 18.2.5 or 17.13.6.

Workarounds

Do not pass untrusted input into messages(), message(), prefs({ messages }), Joi.extend({ messages }) or rule({ message }). Or validate that they don't contain any __proto__ or constructor property.

Severity

  • CVSS Score: 3.7 / 10 (Low)
  • Vector String: CVSS:3.1/AV:N/AC:H/PR:N/UI:N/S:U/C:N/I:L/A:N

References

This data is provided by OSV and the GitHub Advisory Database (CC-BY 4.0).


Release Notes

hapijs/joi (joi)

v18.2.5

Compare Source

v18.2.4

Compare Source


Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate Bot added renovate Renovate bot did it security Security issue or advisory labels Sep 9, 2026
@dex4er

dex4er commented Sep 9, 2026

Copy link
Copy Markdown
Collaborator

@claude check if CVEs affect our project

@claude

claude Bot commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

Claude finished @dex4er's task in 1m 4s —— View job


joi CVE impact analysis

  • Locate every joi usage in the repo
  • Check CVE-2026-84367 (rename() with template target + { multiple: true })
  • Check CVE-2026-84368 (__proto__ key in custom messages)
  • Report conclusion

Neither CVE affects Freelens. The bump is still worth merging (dependency hygiene, and it silences the advisory scanners), but there is no exploitable path in this codebase.

How joi is used here

joi is a direct dependency of packages/core and freelens only — the lockfile has no other package pulling it in, and only joi@18.2.5 resolves after this PR. It is not re-exported through the extension API, so extension code cannot reach it either.

Ten files import it; all of them build plain Joi.object({...}) schemas out of Joi.string() / Joi.boolean() / Joi.array() primitives:

  • packages/core/src/common/cluster-types.ts:36 — cluster model checkers
  • packages/core/src/common/kube-helpers.ts:17-40 — kubeconfig schema
  • packages/core/src/common/k8s-api/endpoints/helm-charts.api.ts:35-84 — Helm chart metadata
  • packages/core/src/renderer/components/dock/logs/log-tab-data.validator.ts:11 — log tab data
  • packages/core/src/main/router/route.ts:67,133 plus the five route injectables under main/routes/{resource-applier,helm/releases} — request payload validators

CVE-2026-84367rename() with a Joi.x() target and { multiple: true }

Not applicable. There is no .rename( call anywhere in the repo that touches joi (the only rename hits are fs.promises.rename in packages/core/src/main/kubectl/kubectl.ts:512 and an unrelated logger method). Consequently there is also no Joi.x() / Joi.expression() and no { multiple: true } — all three preconditions of the advisory are absent.

CVE-2026-84368 — prototype pollution via a __proto__ language key in custom messages

Not applicable. No messages(), message(), prefs({ messages }), Joi.extend({ messages }) or rule({ message }) call exists in the codebase. The only options ever passed to joi are validation flags:

  • kube-helpers.ts:58,62{ abortEarly: false, allowUnknown: true } and { ..., stripUnknown: { arrays: true } }
  • helm-charts.api.ts:209{ abortEarly: false }
  • route.ts:133payloadValidator.validate(payload) with no options

The advisory also notes this path is not reachable from validated data at all; it requires untrusted input fed into schema construction, which never happens here — every schema is a static module-level constant.

Verdict

Merge as routine maintenance. No code change or workaround is needed, and no follow-up mitigation is required in Freelens.

Note: I did not run the build or test suite for this — the question was reachability analysis only, answered by reading the source and the lockfile.
| Branch: renovate/npm-joi-vulnerability | Model: claude-opus-5[1m]

@renovate
renovate Bot force-pushed the renovate/npm-joi-vulnerability branch 3 times, most recently from 502c5bc to 45fca3d Compare September 15, 2026 14:14
@renovate renovate Bot changed the title Update dependency joi to v18.2.5 [SECURITY] Update dependency joi to v18.2.5 [SECURITY] - autoclosed Sep 17, 2026
@renovate renovate Bot closed this Sep 17, 2026
@renovate
renovate Bot deleted the renovate/npm-joi-vulnerability branch September 17, 2026 17:16
@renovate renovate Bot changed the title Update dependency joi to v18.2.5 [SECURITY] - autoclosed Update dependency joi to v18.2.5 [SECURITY] Sep 17, 2026
@renovate renovate Bot reopened this Sep 17, 2026
@renovate
renovate Bot force-pushed the renovate/npm-joi-vulnerability branch 2 times, most recently from 45fca3d to a45b0e7 Compare September 17, 2026 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

renovate Renovate bot did it security Security issue or advisory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant