docs(ghostkey): move backup warning to success page only#31
Merged
Conversation
The backup warning was added to three places in PR #29: the FAQ, the create/donate page, and the success page. Feedback: the warning only matters at the moment the user is actually shown their freshly created key, which is the success page. Putting it on the FAQ and donate pages is noise that dilutes the message when it matters. Remove the warning block from /ghostkey/ (FAQ) and /ghostkey/create/ (donate). Restore the original "Storage, backup, and the CLI" prose on the FAQ page. The stronger success-page warning is unchanged. [AI-assisted - Claude]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
PR #29 added a backup warning to three places: /ghostkey/ (FAQ), /ghostkey/create/ (donate), and /ghostkey/success/ (post-donation). Feedback from @sanity: the warning only matters at the moment the user is actually shown their freshly created key. Putting it on the FAQ and donate pages is noise that dilutes the message when it actually matters.
Approach
Remove the warning from the FAQ and create pages and restore their original prose. The stronger success-page warning is unchanged.
Testing
Content-only; rendered markdown verified by inspection.
[AI-assisted - Claude]