Use component categories from frequenz-client-common#161
Draft
llucax wants to merge 5 commits intofrequenz-floss:v0.x.xfrom
Draft
Use component categories from frequenz-client-common#161llucax wants to merge 5 commits intofrequenz-floss:v0.x.xfrom
frequenz-client-common#161llucax wants to merge 5 commits intofrequenz-floss:v0.x.xfrom
Conversation
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This allows for better interoperability with other API clients. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Now an `unknown` category will be stored as a raw `int` instead of being converted to `UNSPECIFIED`. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
This means we can remove `component_category_from_protobuf()` and now unknown categories will be preserved. Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Signed-off-by: Leandro Lucarella <luca-frequenz@llucax.com>
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ComponentCategoryfromfrequenz-client-commonComponentenum_from_proto()fromfrequenz-client-commonFixes #160.