fix(ci): globally activate melos so exec subprocesses find the binary#56
Merged
Conversation
…nary Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Generated mocks and a handful of non-generated test files still referenced domain types and repository interfaces at their old in-feature paths (e.g. feature_orders/domain/models/order.dart). Those types have since been extracted to shared packages: inventory_contracts, order_management, discounts, catalog, and app_settings. Update every import to the canonical path so dart analyze passes. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ts in mocks
- Update MockOrdersRepository.voidOrder in 3 mocks files: return type
was Result<Order> but interface now returns Result<VoidOrderResult>
(= Record {Order order, bool wasAlreadyVoided}); parameter was int?
but is non-nullable int
- Fix feature_products/domain/* imports in 5 products mock files and
the orphaned products_bloc_test.dart: types were extracted to
package:catalog (models, repositories, blocs)
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…ts in mocks
- Revert accidental VoidOrderResult replacement in createOrder/updateOrder/
completeOrder mock bodies (only voidOrder should return VoidOrderResult)
- Fix order_detail_cubit_test: stub voidOrder with record literal
{order: x, wasAlreadyVoided: false}; replace any with literal 7 for
non-nullable int parameter in verifyNever
- Fix printer_section_test: stale feature_settings/domain and
feature_settings/presentation/blocs imports → package:app_settings
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…peline Branch was 2 commits behind master's formatting fixes; merging alone reintroduced format failures because those master commits were formatted with a different dart format version than the pinned SDK (3.38.5) uses. Re-ran `melos run format:fix` to reconcile. Also fixes issues verified by running the full CI pipeline locally that were blocking `lint`/`test` from ever completing: - products_repository_test.mocks.dart and friends were stale (missing MockInventoryRepository) after a repository interface change; regenerated via build_runner and restored the DAO .g.dart mixins that build_runner incorrectly empties for cross-package drift tables. - printer_section_test.dart had a typo (_alues) that made a mocked field always null, causing undefined_identifier analyzer errors. - app_shell_sidebar.dart had a dead, always-default local parameter shadowing the real showCollapseToggle field. - active_order_bloc_test.dart had an unused discounts import. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
melos run format/lint/testscripts use theexec:directive, which internally spawns child shells that call the baremelosbinary. Since melos was only available as a dev dependency (invoked viadart run melos), it was never on$PATH, causing those child processes to fail withmelos: not found.This adds a step to globally activate melos and append
$HOME/.pub-cache/binto$GITHUB_PATHbefore bootstrapping the workspace, so the binary is resolvable in all subsequent steps.Type of change
Checklist:
fvmfor all flutter commands.fvm flutter format .).fvm flutter analyze).