Open
Conversation
yotamN
force-pushed
the
feature/multiple
branch
3 times, most recently
from
70442d9 to
ece6ff0
Compare
Member
Author
|
I just need to test the build process on Windows and it will be done |
yotamN
force-pushed
the
feature/multiple
branch
26 times, most recently
from
0e97e15 to
e20e896
Compare
yotamN
force-pushed
the
feature/multiple
branch
3 times, most recently
from
cbe2e79 to
9a22fc1
Compare
oleavr
requested changes
Oct 25, 2022
Member
oleavr
left a comment
oleavr
left a comment
There was a problem hiding this comment.
Nice! I guess the only missing piece of the puzzle now is CI for publishing to PyPI. Other than that, just some nitpicks:
setup.py
Outdated
| agents = glob.glob(os.path.join(pkg_dir, "*_agent.*")) | ||
| assert len(agents) > 0, "Agents not compiled; run “npm install && npm run build” in agents/*/" | ||
| os.system("python ./build_aux/build_treesitter.py") | ||
| package_data = agents + ["treesitter.so"] |
Member
There was a problem hiding this comment.
I think we should tie into the build system so we don't do this when just running setup.py to query for something.
Member
Author
There was a problem hiding this comment.
I think this is the only way that a source distribution would build correctly?
yotamN
force-pushed
the
feature/multiple
branch
3 times, most recently
from
48e8dba to
d724268
Compare
yotamN
force-pushed
the
feature/multiple
branch
8 times, most recently
from
dacf269 to
b060ef6
Compare
Member
Author
|
The cross compilation fix was a bit dirty but it seems this is what crossenv is doing as well. |
We need to drop version 3.7 because py-tree-sitter doesn't support it. Luckily, Python 3.7 is EOL for over 2 years so there really should not be anything using it anymore.
We don't compile it outselves anymore
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Kooha-2022-09-24-20-17-49.webm