Skip to content

Migrate from setuptools to meson-python#187

Merged
oleavr merged 5 commits intofrida:mainfrom
oriori1703:build/meson-python
Aug 19, 2025
Merged

Migrate from setuptools to meson-python#187
oleavr merged 5 commits intofrida:mainfrom
oriori1703:build/meson-python

Conversation

@oriori1703
Copy link
Contributor

@oriori1703 oriori1703 commented Jun 6, 2025

While working on publishing wheels I realised the build could be modernised and simplified by using meson-python.

This allows us to use more modern packaging standards (like pyproject.toml) and fits well with the existing meson build system.

TODO:

  • Fix building with frida-python (unless we remove it as suggested in a previous comment) Removed the dependency for now
  • Fix version detection. For now I just hardcoded it in the meson.build
  • Fix license not being recognised by the build system

@oleavr
Copy link
Member

oleavr commented Jun 10, 2025

Nice! The only issue I can see with this approach is that we have a Meson wrapper that takes care of downloading prebuilt tools + libraries. Not sure we want to lose this.

@oriori1703 oriori1703 force-pushed the build/meson-python branch from 610135c to 0c7beca Compare June 10, 2025 22:10
@oriori1703
Copy link
Contributor Author

Nice! The only issue I can see with this approach is that we have a Meson wrapper that takes care of downloading prebuilt tools + libraries. Not sure we want to lose this.

As far as I understand, all of the libraries and tools that are downloaded are not really need when developing frida-tools.
Also, if you still think it is useful to have those tools you can just direct people to the frida/frida repo which functions the same way (download all of the related projects, and all the tools needed to build them).

I have fixed all other issues, so if you agree with removing frida-python as a dependency, everything should be ready to merge 😄

@oriori1703
Copy link
Contributor Author

BTW, The sdist won't build on python 3.7/3.8 unless frida/releng#14 is applied.
The wheels will work fine though :)

@oriori1703 oriori1703 force-pushed the build/meson-python branch from cb36d70 to 99db6ba Compare June 28, 2025 21:26
@oriori1703 oriori1703 force-pushed the build/meson-python branch from 99db6ba to e0c0b69 Compare July 6, 2025 21:33
@oriori1703 oriori1703 force-pushed the build/meson-python branch from 050cfbe to aec4c7c Compare July 19, 2025 15:12
@oleavr oleavr merged commit fefcf57 into frida:main Aug 19, 2025
3 checks passed
@oleavr
Copy link
Member

oleavr commented Aug 19, 2025

Thanks! (And apologies for the delay.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants