Does it make sense to support loading a whole table?

[drusellers]

(agg/load my-model-er the-database :thetable) <- notice no id provided.

[friemen]

Would be possible. The arity-3 load function currently expects a map as 3rd param. The function could test for a keyword and interpret this as: "Load all entities from :thetable". So technically there's no problem.

But is pulling all records from a table a common use case?

I thought in most cases an individual query (with filtering of data) is the starting point, and agg/load can be used for a pull on each loaded record like so:

(->> (my-query-products db-spec)
     (map #(assoc % ::agg/entity :product))
     (map (partial agg/load er-config db-spec))
     doall)

This combines an arbitrary query with the pull feature, and could easily be wrapped into a function.
I'm a bit afraid that your idea opens the door to also support queries in aggregate, which I wanted to keep out of scope.

[drusellers]

Pulling "all" records from a table is a common use case for many developers. Now that said, I would then ask to support a bevy of down the road features like paging and such so that we don't run into unbounded query issues. I really respect your desire to keep queries in aggregate so know that I if I step outside that boundary I'll understand.

That said, am I correct that the above code sample would generate 1+N queries? 1 for the my-query-products then one for each call to agg/load?

Ideally I would like to say something like

(agg/load er-config db-spec {::agg/entity :product :limit 20})

that way I can get the first page of the products. I feel like aggregate could do this easily and it already has all of my "mappings" and it helps save me the N+1 query.

Thank you for your time and well worded responses.

[francoisroyer]

Paging support for child entities would be a big bonus. Any pointer on how this should be implemented?