RSmetanyuk: dragonCurve with direction parameter#9
Open
RSmetanyuk wants to merge 5 commits into
Open
Conversation
RSmetanyuk
changed the title
dosandk
approved these changes
Nov 19, 2018
| export const dragonCurve = n => { | ||
| // logic... | ||
| }; | ||
| export const dragonCurve = (direction, n) => { |
Author
|
Я також заімплементив rotateMatrix (але вже після дедлайну):
RSmetanyuk@f57f282
…On Mon, Nov 19, 2018 at 12:30 PM Vladimir Shevchuk ***@***.***> wrote:
***@***.**** approved this pull request.
------------------------------
In src/dragon-curve/index.js
<#9 (comment)>
:
> @@ -1,3 +1,24 @@
-export const dragonCurve = n => {
- // logic...
-};
+export const dragonCurve = (direction, n) => {
good
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#9 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/Ab5ggJ_yNbuR8O4FwRQFBp7VtFb0JPl4ks5uwohLgaJpZM4YYuZ->
.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
В оригінальному завданні Dragon Curve повертає тільки ліворуч (direction = 1).
Я вирішив ускладнити функцію, додавши можливісь задавати напрямок повороту у вигляді параметра (праворуч: direction = 0, випадково: direction = '').
Також додав можливість задавати напрямки повороту Dragon Curve у вигляді масиву напрямків, де кожен елемент масиву відповідає напрямку повороту (згинання стрічки) на відповідному n-ному порядку функції.