Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
http://endpoints for authenticated network calls by default.PATHwhen invokinggitleaks.Description
validate_network_url,allow_insecure_http, andis_loopback_httphelpers incrates/trace-share-core/src/config.rsand callvalidate_network_urlbefore making network requests for Upstash, worker, and remote registry endpoints.reqwest::Client::builder().no_proxy()and a bounded timeout for outbound client construction inpublish.rs,snapshot.rs, andworker.rs.write_private_fileto atomically write files and set owner-only permissions on Unix, and replace directfs::writeuses for anonymization salt, registry cache, and local sources manifest inpublish.rs,sources.rs, andpublish::load_or_create_anonymization_salt.gitleaksdiscovery insanitize.rsto accept an absolute path viaTRACE_SHARE_GITLEAKS_PATHand otherwise only consider trusted system directories viais_trusted_gitleaks_dir.sources.rs,publish.rs,snapshot.rs, andworker.rsto use the new helpers.docs/SECURITY_AUDIT.mdcontaining findings and recommendations, and bump package versions inCargo.lockto0.0.3for the CLI/core crates.Testing
cargo testacross the workspace and all unit tests completed successfully.Codex Task