Skip to content

ci: publish full releases and name the macOS asset by version#8

Merged
fseiffarth merged 2 commits into
mainfrom
develop
Jul 21, 2026
Merged

ci: publish full releases and name the macOS asset by version#8
fseiffarth merged 2 commits into
mainfrom
develop

Conversation

@fseiffarth

Copy link
Copy Markdown
Owner

Two CI/CD fixes. Both only take effect on a tag push, so they need to reach main to matter.

1. /releases/latest was 404ing

Every release published with prerelease: true. GitHub never marks a pre-release as Latest, so https://github.com/fseiffarth/ProjectEldrun/releases/latest returned 404 — the exact link README.md:121 sends users to in order to download a build.

Verified before the change:

$ gh api repos/fseiffarth/ProjectEldrun/releases/latest
{"message":"Not Found","status":"404"}

Now publishes as a full release. The release notes still describe the build as alpha; this flag is about discoverability, not maturity claims.

2. macOS asset was named by commit SHA

The DMG was renamed to Eldrun-<sha>-universal.dmg while the other three carry the version:

Eldrun-e47219a1836faba620bd828d56038b13d5dadaaa-universal.dmg   ← odd one out
Eldrun_0.1.33_amd64.AppImage
Eldrun_0.1.33_amd64.deb
Eldrun_0.1.33_x64-setup.exe

Now Eldrun_<version>_universal.dmg. Two details:

  • The move is guarded ([ "$dmg" = "$target" ] || mv …) — Tauri may already emit exactly that name, and mv x x fails, which under the step's bash -e would break the macOS package job.
  • The upload glob widens from *-universal.dmg to *universal.dmg so it matches either separator. Without this the rename would silently upload nothing.

Verification

Workflow YAML parses; prerelease reads False. The rename logic was exercised locally in both branches — name already correct (idempotent, no-op) and name differing (renamed) — with the upload glob confirmed to match the result in each.

No application code touched.

🤖 Generated with Claude Code

fseiffarth and others added 2 commits July 21, 2026 16:55
prerelease
- Every release was published with `prerelease: true`, and GitHub never
  marks a pre-release as "Latest". `/releases/latest` therefore 404s — the
  exact link README.md:121 sends users to for a download. Publish as a full
  release; the notes still say alpha, this flag is about discoverability.

macOS asset name
- The DMG was renamed to `Eldrun-<sha>-universal.dmg` while the AppImage,
  deb and exe all carry the version, leaving the one asset a user couldn't
  tie to a release at a glance. Name it `Eldrun_<version>_universal.dmg`.
- The move is now guarded: Tauri may already emit exactly that name, and
  `mv x x` fails. The upload glob widens to `*universal.dmg` so it matches
  either separator.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@fseiffarth
fseiffarth merged commit f3648ae into main Jul 21, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant