ci: publish full releases and name the macOS asset by version#8
Merged
Conversation
prerelease - Every release was published with `prerelease: true`, and GitHub never marks a pre-release as "Latest". `/releases/latest` therefore 404s — the exact link README.md:121 sends users to for a download. Publish as a full release; the notes still say alpha, this flag is about discoverability. macOS asset name - The DMG was renamed to `Eldrun-<sha>-universal.dmg` while the AppImage, deb and exe all carry the version, leaving the one asset a user couldn't tie to a release at a glance. Name it `Eldrun_<version>_universal.dmg`. - The move is now guarded: Tauri may already emit exactly that name, and `mv x x` fails. The upload glob widens to `*universal.dmg` so it matches either separator. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two CI/CD fixes. Both only take effect on a tag push, so they need to reach
mainto matter.1.
/releases/latestwas 404ingEvery release published with
prerelease: true. GitHub never marks a pre-release as Latest, sohttps://github.com/fseiffarth/ProjectEldrun/releases/latestreturned 404 — the exact linkREADME.md:121sends users to in order to download a build.Verified before the change:
Now publishes as a full release. The release notes still describe the build as alpha; this flag is about discoverability, not maturity claims.
2. macOS asset was named by commit SHA
The DMG was renamed to
Eldrun-<sha>-universal.dmgwhile the other three carry the version:Now
Eldrun_<version>_universal.dmg. Two details:[ "$dmg" = "$target" ] || mv …) — Tauri may already emit exactly that name, andmv x xfails, which under the step'sbash -ewould break the macOS package job.*-universal.dmgto*universal.dmgso it matches either separator. Without this the rename would silently upload nothing.Verification
Workflow YAML parses;
prereleasereadsFalse. The rename logic was exercised locally in both branches — name already correct (idempotent, no-op) and name differing (renamed) — with the upload glob confirmed to match the result in each.No application code touched.
🤖 Generated with Claude Code