Re-enable NoPartialFunctions in SelfCheck #810
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webwarrior-ws
force-pushed
the
wip/fsc-bug-2
branch
from
44f1fbb to
d6ca67b
Compare
knocte
reviewed
Dec 31, 2025
knocte
reviewed
Dec 31, 2025
knocte
reviewed
Dec 31, 2025
knocte
reviewed
Dec 31, 2025
In src/FSharpLint.Core/Application/Configuration.fs to avoid FSC bug
that leads to error:
```
Failed to parse file D:\Projects\work\FSharpLint\src\FSharpLint.Core\Application\Configuration.fs
Exception Message:
The exception has been reported. This internal exception should now be caught at an error recovery point on the stack. Original message: ConstraintSolverMissingConstraint
({ includeStaticParametersInTypeNames = false
openTopPathsSorted =
Internal.Utilities.Library.InterruptibleLazy`1[Microsoft.FSharp.Collections.FSharpList`1[Microsoft.FSharp.Collections.FSharpList`1[System.String]]]
openTopPathsRaw = []
shortTypeNames = false
suppressNestedTypes = false
maxMembers = None
showObsoleteMembers = false
showHiddenMembers = false
showTyparBinding = false
showInferenceTyparAnnotations = false
suppressInlineKeyword = true
suppressMutableKeyword = false
showMemberContainers = false
shortConstraints = false
useColonForReturnType = false
showAttributes = false
showCsharpCodeAnalysisAttributes = false
showOverrides = true
showStaticallyResolvedTyparAnnotations = true
showNullnessAnnotations = None
abbreviateAdditionalConstraints = false
showTyparDefaultConstraints = false
showDocumentation = false
shrinkOverloads = true
printVerboseSignatures = false
escapeKeywordNames = false
g = <TcGlobals>
contextAccessibility = public
generatedValueLayout = <fun:Empty@3228>
genericParameterStyle = Implicit }, Config,
SupportsComparison (139,4--139,10), (139,4--139,10), (139,4--139,10)))
```
Also added FSharpx.Collections library because NoPartialFunctions rule recommends tryHeadTail function from this library instead of tail functions.
By making tryFindTypedExpression function tail-recursive.
webwarrior-ws
force-pushed
the
wip/fsc-bug-2
branch
from
d6ca67b to
26e257f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Worked around FCS bug that prevented linting src/FSharpLint.Core/Application/Configuration.fs file.