Skip to content

build(deps-dev): bump typescript from 6.0.3 to 7.0.2 in /apps/netscli-gui - #134

Closed
dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/apps/netscli-gui/typescript-7.0.2
Closed

dependabot[bot] wants to merge 1 commit into
mainfrom
dependabot/npm_and_yarn/apps/netscli-gui/typescript-7.0.2

Conversation

@dependabot

@dependabot dependabot Bot commented on behalf of github Jul 9, 2026 •

Copy link
Copy Markdown
Contributor

Bumps typescript from 6.0.3 to 7.0.2.

Commits
Maintainer changes

This version was pushed to npm by microsoft1es, a new releaser for typescript since your current version.


Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

@dependabot dependabot Bot added dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code labels Jul 9, 2026
@fstubner

Copy link
Copy Markdown
Owner

@dependabot rebase

Bumps [typescript](https://github.com/microsoft/TypeScript) from 6.0.3 to 7.0.2.
- [Release notes](https://github.com/microsoft/TypeScript/releases)
- [Commits](https://github.com/microsoft/TypeScript/commits)

---
updated-dependencies:
- dependency-name: typescript
  dependency-version: 7.0.2
  dependency-type: direct:development
  update-type: version-update:semver-major
...

Signed-off-by: dependabot[bot] <support@github.com>
@dependabot
dependabot Bot force-pushed the dependabot/npm_and_yarn/apps/netscli-gui/typescript-7.0.2 branch from aea5e8e to 39ba858 Compare August 15, 2026 04:04
@fstubner

Copy link
Copy Markdown
Owner

Tested this locally against main rather than guessing at it. The codebase is already TS 7 ready — the blocker is typescript-eslint.

Check TS 7.0.2
tsc -b ✅ clean
vite build ✅ clean
vitest run ✅ 94 passed
npm run lint ❌ crashes
typescript-eslint does not support TS 7.0.
Please see https://devblogs.microsoft.com/typescript/announcing-typescript-7-0/#running-side-by-side-with-typescript-6.0
See also https://github.com/typescript-eslint/typescript-eslint/issues/10940 for tracking
typescript-eslint's support for TS >=7.1

Note the tracking issue targets >= 7.1, so 7.0.2 specifically will not be supported — this needs a later TypeScript, not a later typescript-eslint alone.

Why that's disqualifying rather than a nuisance

The lint gate went in yesterday (C-22 — the GUI had no ESLint config at all, which AGENTS.md acknowledged). It carries react-hooks/rules-of-hooks and exhaustive-deps, which are precisely the rules for the stale-closure and dependency-array bugs this project has actually shipped:

  • A-13 — a setTimeout closure captured the pre-switch tab and selected a row in the wrong one
  • B-16 — an effect keyed on sort state wiped the destination tab's selection on every tab switch
  • B-18 — a document-level keydown listener detached and reattached on every render

Taking TS 7.0 now means dropping that gate to gain nothing we need. Microsoft documents a side-by-side workaround (keep TS 6 installed purely for eslint), but that's real complexity to carry for a devDep bump with no feature attached.

Recommendation

Leave this open. It should go green on its own once typescript-eslint ships TS 7.x support and Dependabot bumps this to >= 7.1. Nothing in the repo needs changing in the meantime — tsc -b and the build already pass under 7, so there's no migration debt accruing.

Re-run the four checks above when this next updates; if lint passes, it's mergeable as-is.

@fstubner

Copy link
Copy Markdown
Owner

Correcting my previous comment — the reason I gave was wrong in a way that points at the wrong package.

I said this "needs Dependabot to bump it past 7.1 first", implying a newer TypeScript would unblock it. Checked properly:

$ npm view typescript-eslint@latest peerDependencies
{ "typescript": ">=4.8.4 <6.1.0" }

typescript-eslint@8.67.0 is the latest release, it is what we already have, and it caps at <6.1.0 — it does not support TypeScript 6.1, let alone 7.x. The canary (8.67.1-alpha.4) has the same range. Our 6.0.3 sits just under the ceiling.

Two consequences:

  1. No TypeScript version unblocks this. Bumping anywhere past 6.0.x breaks lint; nothing about 7.x specifically. My framing made this look like a TS-7 problem when it is a typescript-eslint support problem.
  2. There is no stable 7.1 to bump to regardless — only 7.1.0-dev.* nightlies. Latest stable is 7.0.2.

The only thing that unblocks it is typescript-eslint publishing a release that widens its own peer range (typescript-eslint#10940). Watch that package, not this one.

Everything else in my earlier comment still holds and was measured, not assumed: under TS 7.0.2 tsc -b, vite build and all 94 tests pass — only npm run lint fails. So there is no migration debt accruing while this waits.

@fstubner

Copy link
Copy Markdown
Owner

Same upstream block as #213, and this branch has also gone stale enough to conflict (six weeks, DIRTY). The TypeScript 7 major is not installable while our tooling pins older peer ranges.

Closing rather than carrying a permanently failing PR. Dependabot will open a new one against current main when the next version lands.

@fstubner fstubner closed this Aug 24, 2026
@dependabot @github

dependabot Bot commented on behalf of github Aug 24, 2026

Copy link
Copy Markdown
Contributor Author

OK, I won't notify you again about this release, but will get in touch when a new version is available. If you'd rather skip all updates until the next major or minor version, let me know by commenting @dependabot ignore this major version or @dependabot ignore this minor version. You can also ignore all major, minor, or patch releases for a dependency by adding an ignore condition with the desired update_types to your config file.

If you change your mind, just re-open this PR and I'll resolve any conflicts on it.

@dependabot
dependabot Bot deleted the dependabot/npm_and_yarn/apps/netscli-gui/typescript-7.0.2 branch August 24, 2026 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file javascript Pull requests that update javascript code

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant