Repository navigation
Make the e2e assertions capable of failing - #199
Merged
Merged
Conversation
Four scenarios could not fail, which is worse than not having them: they report green regardless, so the suite's coverage looks larger than it is. Counts that matched zero: discover /\d+ hosts?/ matched "0 hosts" sweep /\d+ hosts? .* \d+ with open ports?/ interfaces /\d+ interfaces?/ All three now require [1-9]\d*. Each targets something guaranteed present: discover and sweep run against 127.0.0.0/30, which contains the loopback address the probe server listens on, and every machine has at least a loopback interface. A total backend regression in any of them used to go green. ARP deliberately still tolerates zero, and now says why: an empty neighbour cache is legitimate on a freshly booted runner, so requiring >= 1 would be flaky rather than strict. A hard failure is still caught, because the status bar would show an error rather than a count. The pcap scenario returned false and passed when the Packet Capture menu item was missing, so the whole capture surface disappearing was indistinguishable from a healthy skip. Now that builds without the feature keep the tool visible and show setup guidance (#193), an absent entry means something broke -- so it is a hard assertion. The unavailable branch also asserts the guidance names the feature and says how to get a capture-capable build, rather than only checking the element exists. Two silent skips: - `closeSettingsDialog` returned quietly when `.settings-close` was absent, so a dialog that could no longer be dismissed left the suite green and every later step ran against a still-open modal. Now an assertion. - `assertInterfaceReadinessReflectsSelection` early-returns on a host with no down interface. That is a real skip, but it now logs SKIP with the reason instead of reading like a pass. Verified by `node --check` and by reading. NOT executed: the render harness cannot pass on this host (WebView2 ignores the remote-debugging port on an elevated session, wry#1782), and gui-render.yml is schedule-only for the same reason. These changes are therefore unexercised until that is resolved -- which is worth stating plainly, since the whole point of the change is not trusting assertions that were never really running.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See the commit message for the full reasoning — it is the detailed record for this change.