Repository navigation
Set the Windows installer's publisher to Felix Stubner, and test the upgrade - #513
Merged
Merged
Conversation
…upgrade Without bundle.publisher, Tauri uses the identifier's second segment, so the MSI's Manufacturer, and with it Installed apps, said "netscli" while the signature, winget and the Store listing say Felix Stubner. The WiX template also names per-user registry keys after the manufacturer, so the new installer-upgrade workflow installs the last release and then this build over it on a Windows runner, and checks for one Installed apps entry with the new publisher and version, a working Start menu shortcut, and no key left under the old name.
Contributor
|
Site preview: https://pr-513.netscli-site-preview.pages.dev Built from e3cd541 with Production is unaffected: netscli.com is served from GitHub Pages via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Installed apps lists the desktop app's publisher as netscli, Tauri's default (the identifier's second segment), while the code signature, winget and the Microsoft Store listing all say Felix Stubner. The Store's validation reads that entry.
Sets
bundle.publisher. The WiX template also names per-user registry keys after the manufacturer (HKCU\Software\<publisher>\NetsCLI), so the change needs proving on an upgrade, not only a fresh install.New check:
installer-upgrade.yml. On a Windows runner it installs the last released MSI, then this branch's MSI (built unsigned at version 0.99.0) over it, and fails unless:C:\Program Files\NetsCLI\netscli-gui.exeexists and the Start menu shortcut points at a real fileIt runs on PRs that touch
tauri.conf.jsonor the WiX template, and on demand.Does not affect the current Store submission, which is pinned to the 0.3.4 MSI. Ships with 0.3.5. Per-user install scope is tracked separately in #512.