Repository navigation
Privacy page: text into site-content, page into a shell - #533
Merged
Merged
Conversation
So the template can share the page. privacy.astro now only renders privacyCopy from src/data/site-content/privacy.ts, the way the other sections read their content files; the built page's text is unchanged (compared before and after).
Contributor
|
Site preview: https://pr-533.netscli-site-preview.pages.dev Built from fd58b12 with Production is unaffected: netscli.com is served from GitHub Pages via |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For the template sync.
privacy.astrohad netscli's policy written into it, so the template could only take it as netscli's text. Now the page rendersprivacyCopyfromsrc/data/site-content/privacy.ts(typed inprivacy-types.ts), like the other sections, and the template can share the page while keeping its own sample text.The built page's text is identical before and after (compared on the rendered
<main>). Structured-data and CSS checks pass.