Keep the promo video rig out of the repo - #3
Merged
Merged
Conversation
Keep the promo video rig out of the repo. The capture harness, the Veo and Lyria generators and the `lib/` hooks the walk reads are marketing tooling, same as the listing copy already ignored under store/, and the walk cannot sit in the tree without them: `flutter analyze` fails on hooks that are not applied. `tools/promo/capture.sh` stages both for the length of a run. Also widen the __pycache__ rule, which only covered tools/ itself.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The promo capture harness (
tools/promo/), its Veo/Lyria generators and theintegration_test/promo_walk_test.dartwalk are marketing tooling, the same class as the listing copy already ignored understore/. They stay local.The walk reads two
@visibleForTestinghooks inlib/, so it cannot sit in the tree with those hooks unapplied -flutter analyzefails on it.tools/promo/capture.shnow stages the hooks and the walk for the length of a run and removes them again on exit, interrupt included.Also widens
tools/__pycache__/to**/__pycache__/, which the old rule missed one level down.1.15.1+27 -> 1.15.2+28.