Skip to content

bug: grok-build pid walk falls through to claude/codex/gemini #859

Description

@apstndb

Summary

_agmsg_agent_binaries has no grok-build arm, so the type falls through to claude codex gemini. agmsg_agent_pid grok-build therefore does not see a live grok process, and grok-build watchers are not liveness-gated.

This is the same function that needs a cursor arm for cursor monitor, but the grok mapping does not depend on that work. Split out of #856. Independently mergeable (#860).

Manifest already has detect_proc=grok grok-*. Reading that key for plugins stays a follow-up (#631).

Do not add agent. Homebrew grok-build and the Cursor CLI installer both use that basename; the policy lives on #856. #860 comments the omission.

#858 stays a draft until this and #857 have landed.

Repro

. scripts/lib/resolve-project.sh
_agmsg_agent_binaries grok-build    # claude codex gemini  (wrong)

Fix, before the * arm:

grok-build)  echo "grok" ;;

The matcher already accepts "$bin"|"$bin"-*. Observed 2026-08-18: live grok pid 2469, vanilla NO, one-arm patch YES.

Do not change grok "${GROK_SESSION_ID:--}" callers.

Related

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions