fix(#894): detect systemd-supervised sync engines - #1006
Open
joelmitz wants to merge 2 commits into
Open
Conversation
joelmitz
added a commit
to joelmitz/agmsg
that referenced
this pull request
Aug 28, 2026
fix(fujibee#894): detect systemd-supervised sync engines (local patch, upstream PR fujibee#1006 pending)
joelmitz
force-pushed
the
fix/894-systemd-engine-detection
branch
from
September 12, 2026 15:48
3a1cf8e to
0ba9d1c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes the duplicate-engine failure described in #894.
Design
The probe validates the MainPID liveness and the exact remote-sync engine/team argv before calling an active unit running. If the unit is active but identity cannot be verified, sync start fails closed instead of creating an unmanaged duplicate. If the unit is inactive or failed, sync start refuses and directs the operator to the systemd user unit.
A hook-only change would miss direct sync start callers. Writing a pidfile from the service would reintroduce pidfile ownership and TOCTOU risks. Therefore the ownership probe is shared at the remote CLI boundary.
Related: #894