test(codex): pin the ws:// port-file fallback in the SessionStart plug (#1056) - #1172
Merged
Conversation
#1056) Adds coverage for the fourth app-server discovery fallback introduced in #1057: with AGMSG_CODEX_BRIDGE_APP_SERVER unset, no unix:// token on the agent's cmdline, and no .sock file, the SessionStart plug still finds a ws:// app-server through its port file and writes the codex-bridge-request with that URL.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds tests/test_delivery.bats coverage for the fourth app-server discovery fallback that #1057 introduced in the codex SessionStart plug: with AGMSG_CODEX_BRIDGE_APP_SERVER unset, no unix:// token on the agent's cmdline, and no .sock file, the plug finds a ws:// app-server through its port file and writes the codex-bridge-request with that URL. Measured directly: the test is red on the commit immediately before #1057 landed on main, and green from #1057 onward. Refs #1056.