feat(qualityflow): dispatch QF on the ready-tests label (POC) - #173
Draft
guyoron1 wants to merge 2 commits into
Draft
feat(qualityflow): dispatch QF on the ready-tests label (POC)#173guyoron1 wants to merge 2 commits into
guyoron1 wants to merge 2 commits into
Conversation
Register harness/qualityflow-ready-tests.yaml, a base: child of the pinned QualityFlow harness with its own CEL trigger: label_changed/added 'ready-tests' on a non-fork PR. The existing /fs-plan-tests comment trigger on the base harness is unchanged. Verified with 'fullsend dispatch --input-driver json' against a labeled-PR fixture. Signed-off-by: guy oron <goron@redhat.com>
This org is still in per-org mode, so dispatch.yml's bash routing decides stages, not harness CEL. Mirror the new harness trigger: pull_request_target labeled 'ready-tests' on a non-fork PR -> qualityflow stage. qualityflow.yml falls back to pull_request.html_url for GITHUB_ISSUE_URL since the label payload has no issue object. Both go away when the org leaves per-org mode. Signed-off-by: guy oron <goron@redhat.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Draft / POC for the 2026-08-19 contributors meeting — not ready for review.
Dispatch QualityFlow when a PR receives the
ready-testslabel (set by a coverage check_run → label workflow, see fullsend core draft PR), so test planning aims at the measured coverage gap instead of only firing on/fs-plan-tests.harness/qualityflow-ready-tests.yaml(new):base:child of the pinned QF harness with its own CEL triggerlabel_changed && label.name == "ready-tests" && action == "added" && !is_fork(trigger is not inherited from base, so/fs-plan-testson the base keeps working). Registered inconfig.yamlagents[].dispatch.ymlgains apull_request_target labeled ready-tests→STAGE=qualityflowcase (non-fork guard, still undermax-lines=600);qualityflow.ymlfalls back topull_request.html_urlforGITHUB_ISSUE_URLsince a label payload has noissue.Verified:
fullsend dispatch --input-driver json --output-driver json --config-dir .against aready-tests-labeled PR event matchesqualityflow-ready-tests(role coder);pr-openedand aready-otherlabel → null. YAML parses; route scriptbash -n.Depends on the label existing (label workflow) — until then only the manual
/fs-plan-testspath is exercised. Per-org placement is knowingly temporary (ADR 0044).