fix: Do not recommend good first issue on bot-authored issues - #1002
Closed
VedantMadane wants to merge 1 commit into
Closed
fix: Do not recommend good first issue on bot-authored issues#1002VedantMadane wants to merge 1 commit into
VedantMadane wants to merge 1 commit into
Conversation
- issue-labels github skill: check author before newcomer labels - Skip good first issue / first-timers-only when author is a bot Fixes fullsend-ai#200 Signed-off-by: Vedant Madane <6527493+VedantMadane@users.noreply.github.com>
|
Thank you for your interest in contributing, @VedantMadane. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
Functional tests did not runFunctional tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the |
PR Summary by QodoSkip newcomer label recommendations for bot-authored issues
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
1. Protected skill files modified
|
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
Comment on lines
+67
to
+70
| ## Step 3b: Skip newcomer labels on bot-authored issues | ||
|
|
||
| Before recommending labels, check who opened the issue: | ||
|
|
There was a problem hiding this comment.
1. Protected skill files modified 📜 Skill insight § Compliance
The PR modifies files under the protected skills/ governance path. These changes require human approval and must not be auto-approved, even though the PR links issue #200.
Agent Prompt
## Issue description
This PR changes a file under the protected `skills/` path, which must not be auto-approved.
## Issue Context
The compliance policy requires a review finding for any protected-path modification, with human approval before merge.
## Fix Focus Areas
- skills/issue-labels/github/SKILL.md[67-70]
- skills/issue-labels/gitlab/SKILL.md[62-64]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+75
to
+80
| If the author is a bot (.author.is_bot is true, login ends with [bot], or | ||
| the account is clearly automation such as dependabot, | ||
| enovate, | ||
| github-actions, or a *-bot service account), **do not** recommend | ||
| good first issue, good-first-issue, irst-timers-only, or equivalent | ||
| newcomer labels. Bot-filed issues are not onboarding work for humans. |
There was a problem hiding this comment.
2. Bot-label detection contains typos 📜 Skill insight ≡ Correctness
The GitHub skill's bot-account examples misspell renovate as enovate, and the first-timers-only label contains a corrupted control character. As written, the documented guard may fail to recognize Renovate-authored issues and cannot reliably exclude the intended newcomer label from bot-authored issue recommendations.
Agent Prompt
## Issue description
Correct the bot detection and newcomer-label examples in the GitHub skill: spell `renovate` correctly and restore the exact `first-timers-only` label so bot-authored issues are not recommended for human onboarding labels.
## Issue Context
The guard should recognize Renovate automation while retaining the existing generic `.author.is_bot`, `[bot]`, and `*-bot` checks. The instruction must use the real `first-timers-only` label so bot-authored issues are excluded from that recommendation.
## Fix Focus Areas
- skills/issue-labels/github/SKILL.md[75-80]
- skills/issue-labels/github/SKILL.md[79-80]
- skills/issue-labels/github/SKILL.md[75-78]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+71
to
+73
| ` | ||
| gh issue view NUMBER --repo OWNER/REPO --json author | ||
| ` |
There was a problem hiding this comment.
3. Malformed author query block 🐞 Bug ≡ Correctness
The new gh issue view command is surrounded by single backticks rather than a fenced Markdown code block, unlike the executable commands elsewhere in the skill. This makes the required author lookup ambiguous to the sub-agent and can cause it to treat the command as inline text instead of an operation to run.
Agent Prompt
## Issue description
The author lookup is delimited with single backticks, so it is rendered as inline code rather than a clear executable command block.
## Issue Context
Other executable commands in this skill use fenced Markdown blocks. Preserve the command exactly, but delimit it consistently so the sub-agent can execute it.
## Fix Focus Areas
- skills/issue-labels/github/SKILL.md[71-73]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+62
to
+64
| ## Bot-authored issues | ||
|
|
||
| Do not recommend good first issue on bot-authored issues. |
There was a problem hiding this comment.
4. Gitlab bot rule lacks author data 🐞 Bug ≡ Correctness
The GitLab skill says not to recommend newcomer labels for bot-authored issues but provides no procedure for identifying bots, while its preceding issue query only retrieves IID, title, and labels. Consequently the sub-agent lacks the author information needed to apply the new rule.
Agent Prompt
## Issue description
The GitLab bot-authored issue rule is not actionable because the skill neither explains bot detection nor retrieves author data.
## Issue Context
Update the GitLab issue lookup to include the author/author username (or add a per-issue author query), then document the relevant GitLab bot-account indicators before label recommendations.
## Fix Focus Areas
- skills/issue-labels/gitlab/SKILL.md[48-53]
- skills/issue-labels/gitlab/SKILL.md[62-64]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Do not recommend good first issue on bot-authored issues
Changes
Fixes #200