chore: repin harness images to the v0.37.0 release builds (ship the xai-vertex pi extension) - #1025
Conversation
PR Summary by QodoBump harness images for xAI Vertex pi support
AI Description
Diagram
High-Level Assessment
Files changed (7)
|
Code Review by Qodo
1.
|
|
🤖 Review · Commit: |
…ai-vertex pi extension) The seven harness image: pins point at sandbox 9af3fba / code 9743bc7b, built 2026-08-23 from fullsend 1f027be5 during the aborted first v0.37.0 attempt (they even carry the 0.37.0 version label). The v0.37.0 that actually shipped (2026-08-25, fullsend 84c8bbbb = the merge of #6572, which vendors the pi-xai-vertex extension into the sandbox image) pushed new 0.37.0 images: sandbox 46adf184 and code 7b2bcbdb. The old pins have no /usr/local/share/pi-extensions/xai-vertex, so any agent selecting an xai-vertex/... model on pi fails at startup: Error: Failed to load extension "/usr/local/share/pi-extensions/xai-vertex": Extension path does not exist Error: Model "xai-vertex/xai/grok-4.6" not found. Seen on fullsend-ai/pi-xai-vertex triage run 32880776870. Pins reference release-tagged digests, not main :latest, because a fullsend release tags agents main as-is (resolveAgentsRef fetches agents@tags/<version> for release CLI builds), so whatever sits here ships to that version's users. Verified with "podman run --pull=always ... ls /usr/local/share/pi-extensions" that both 0.37.0 digests list anthropic-vertex and xai-vertex, and the old digests list anthropic-vertex only. Signed-off-by: Wayne Sun <gsun@redhat.com>
cac8b3f to
01d4242
Compare
|
🤖 Finished Review · ✅ Success · Started 6:19 PM UTC · Completed 6:35 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.16 |
|
Risk Assessment: moderate (2/5) DetailsLow-risk config-only change repinning 7 harness image tags to v0.37.0; Tier 1 is low (1.88) due to minimal line changes and no security/CI/dependency impact, but Tier 2 is elevated (3.50) because these harness files are high-churn, multi-author hotspots with frequent fix commits - composite rounds to moderate. |
ReviewFindingsMedium
|
|
🤖 Finished Retro · ✅ Success · Started 7:30 PM UTC · Completed 7:40 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $4.35 |
|
PR #1025 was a human-authored fix for stale harness image pins that were blocking xai-vertex model use on the pi runtime. The seven harness image: pins pointed at builds from the aborted first v0.37.0 attempt instead of the actual v0.37.0 release. The author (waynesun09) manually repinned all seven digests. The first commit contained incorrect digests; the author caught this and force-pushed an amendment within 8 minutes, cancelling the first review agent run (~7 min wasted compute). The second review completed at $3.16 (opus/high effort), correctly flagging the harness/ protected-path policy requirement. A human reviewer approved and the PR merged cleanly via merge queue in ~1h20m. The workflow was well-executed with no significant quality issues. The systemic root cause — manual image repin after each fullsend release — is comprehensively tracked by fullsend-ai/fullsend#6607, which was filed by the same author alongside this PR. No improvement proposals are warranted that are not already covered by existing open issues. |
Why
The seven harness
image:pins point at builds from the aborted first v0.37.0 attempt (2026-08-23, fullsend rev1f027be5— they even carry the0.37.0OCI version label). The v0.37.0 that actually shipped on 2026-08-25 is fullsend84c8bbbb, the merge of fullsend#6572, which vendors thepi-xai-vertexextension into the sandbox image. The registry's0.37.0tags now point at that build, but these pins were never moved, so the pinned images have no/usr/local/share/pi-extensions/xai-vertexand any agent selecting anxai-vertex/...model on pi fails at startup:First seen on fullsend-ai/pi-xai-vertex triage run https://github.com/fullsend-ai/pi-xai-vertex/actions/runs/32880776870 — that repo's
.fullsend/config.yaml(fullsend-ai/pi-xai-vertex#1) puts triage/review onxai-vertex/xai/grok-4.6via the per-agentagents:settings from fullsend#6583. Selection itself worked (Model: xai-vertex/xai/grok-4.6 (from … agents.triage),Runtime: pi); only the image content is stale.What
Seven
image:pins → the digests behind the registry's0.37.0tags (rev84c8bbbb). No other change.1f027be5):0.37.0, rev84c8bbbb)fullsend-sandbox(triage, retro, prioritize, scribe)9af3fba…46adf184…fullsend-code(code, review, fix)9743bc7b…7b2bcbdb…reviewis included because pi-xai-vertex runs review on Grok too.Convention: pins reference release-tagged digests, not main
:latest. A fullsend release tags agentsmainas-is (resolveAgentsRef()makes release CLI builds fetchagents@tags/<version>), so whatever sits here ships to that version's users; a:latestpin would silently ship whatever the last main image build changed. The design has an inherent one-release lag (an agents tag can't reference its own release's images) — that's the pin-design item already tracked on the release-gate page, not addressed here.Verification
podman run --rm --pull=always --entrypoint ls <image> /usr/local/share/pi-extensions:fullsend-sandbox@sha256:46adf184…→anthropic-vertex xai-vertexfullsend-code@sha256:7b2bcbdb…→anthropic-vertex xai-vertex9af3fba…/9743bc7b…→anthropic-vertexonlyskopeo inspect docker://ghcr.io/fullsend-ai/fullsend-{sandbox,code}:0.37.0→org.opencontainers.image.revision: 84c8bbbb…, created 2026-08-25 01:27/01:38 UTC.Neither
.fullsend/config.yamlnor a new fullsend release changes the image a CI run uses (FULLSEND_SANDBOX_IMAGEis local-dev only), so this pin is the lever. Per-repo consumers on fullsendmainresolvefullsend-ai/agents@main, so it takes effect on merge.