Skip to content

refactor(#1053): replace TRIGGER_ENTITY_URL with FULLSEND_WORK_ITEM_URL - #1054

Merged
ralphbean merged 1 commit into
mainfrom
agent/1053-replace-trigger-entity-url
Aug 26, 2026
Merged

refactor(#1053): replace TRIGGER_ENTITY_URL with FULLSEND_WORK_ITEM_URL#1054
ralphbean merged 1 commit into
mainfrom
agent/1053-replace-trigger-entity-url

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Testing

  • All triage-related shell script tests pass (pre-triage-test.sh, post-triage-test.sh).
  • check-bundle confirms bundled scripts are consistent.
  • No test scripts referenced the old variable name — the rename is purely in configuration and documentation.

Closes #1053

Post-script verification

  • Branch is not main/master (agent/1053-replace-trigger-entity-url)
  • Secret scan passed (gitleaks — 2fbb7da338097ad4c3d659820444c7523a0f1e63..HEAD)
  • PR body secret scan passed (gitleaks — no-git)

Rename the Jira forge env var from TRIGGER_ENTITY_URL to
FULLSEND_WORK_ITEM_URL across all references: harness config
(triage.yaml runner and sandbox env), the Jira env file
(env/jira/triage.env), documentation (docs/triage.md), and
the local testing guide (LOCAL.md).

This aligns with the decision in fullsend-ai/fullsend#6611
to standardize on FULLSEND_WORK_ITEM_URL.

Note: pre-commit could not fetch remote hook repos due to
sandbox network restrictions. Hooks were run directly
(YAML validation, trailing whitespace, end-of-file, private
key detection, gitleaks) and all passed.

Closes #1053
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner August 26, 2026 20:22
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Triggers review agent dispatch label Aug 26, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 26, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:24 PM UTC · Completed 8:36 PM UTC

Commit: 975ce4b · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.58

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Aug 26, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Straightforward env-var rename across 4 config/doc files by a known bot; minimal change size and perfect issue-scope alignment keep risk low, but moderate historical churn and fix-commit density on the touched files nudge the composite to moderate.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Aug 26, 2026
@ralphbean
ralphbean added this pull request to the merge queue Aug 26, 2026
Merged via the queue into main with commit a81ec79 Aug 26, 2026
77 of 85 checks passed
@ralphbean
ralphbean deleted the agent/1053-replace-trigger-entity-url branch August 26, 2026 21:19
@fullsend-ai-retro

fullsend-ai-retro Bot commented Aug 26, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 9:21 PM UTC · Completed 9:34 PM UTC

Commit: 975ce4b · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $5.53

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #1054 — Replace TRIGGER_ENTITY_URL with FULLSEND_WORK_ITEM_URL

Timeline

Time (UTC) Event
20:14:25 Issue #1053 opened by ralphbean
20:14:28 Triage agent dispatched (run 33009396141)
20:14:31 /fs-code command posted
20:14:35 Code agent dispatched (run 33009405532)
20:20:28 Triage agent completes — identifies 3 affected files
20:21:09 Code agent completes (3m42s, $2.22) — finds and changes 4 files
20:22:03 PR #1054 created
20:22:07 Review agent dispatched (run 33010039535)
20:25:51 Human approves PR
20:36:20 Review agent completes (14 min, $2.58) — posts risk assessment (moderate 2/5) and one protected-path finding
20:47:47 Functional tests pass (after ok-to-test label applied)
21:19:10 PR merged

Workflow quality

Code agent: Excellent. Completed a clean 7-line rename across 4 files in under 4 minutes, passed all pre-commit hooks, and required zero rework. Notably, the code agent found an additional file (env/jira/triage.env) that the triage agent's analysis missed.

Triage agent: Completed quickly but its affected-files analysis was incomplete — it listed 3 files (6 occurrences) but missed env/jira/triage.env (1 occurrence). The triage agent's proposed verification command scoped its grep to specific directories (harness/, docs/, LOCAL.md) rather than searching the full repository, which is why the env/ directory was overlooked.

Review agent: Ran correctly and produced accurate findings. The sole posted finding (protected-path flag on harness/triage.yaml) was valid. The risk assessment (moderate 2/5) provided useful context. The review agent internally generated 18 findings but filtered to 1, showing effective noise reduction.

Functional tests: Two intermediate failures on label events (risk/moderate, requires-manual-review) were expected fail-closed behavior — no tests actually ran in those cases. Tests passed once ok-to-test was applied.

Evidence for existing issues

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ok-to-test ready-for-review Triggers review agent dispatch requires-manual-review Review requires human judgment risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Replace TRIGGER_ENTITY_URL with FULLSEND_WORK_ITEM_URL

1 participant