fix(#552): add DCO sign-off prohibition to fix and code agent definitions - #1094
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#552): add DCO sign-off prohibition to fix and code agent definitions#1094fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
…ions The prohibition against `git commit -s` and `Signed-off-by` trailers existed only in the skills (code-implementation and fix-review), which appear later in context and sometimes lose to the target repo's earlier positive mention of DCO sign-off. This caused repeated post-script rejections on multiple PRs across fullsend-ai/fullsend, wasting entire agent runs. Add an explicit constraint to the Constraints section of both agents/fix.md and agents/code.md so the rule appears early in context where the model is most likely to internalize it. The skill-level prohibition remains as a second layer of defense. Closes #552
|
🤖 Finished Review · ✅ Success · Started 2:12 PM UTC · Completed 2:25 PM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.35 |
|
Risk Assessment: moderate (2/5) DetailsDocs-only change with minimal surface area (6 lines, 2 files, small blast radius) to protected agent definition files; moderate risk due to multi-author contention and elevated fix/revert history in target files, but straightforward scope and complete acceptance criteria coverage reduce overall risk. |
ReviewFindingsMedium
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git commit -s/Signed-off-byprohibition to the Constraints section of bothagents/fix.mdandagents/code.mdcode-implementation/SKILL.mdandfix-review/SKILL.md), which appear later in context and were sometimes overridden by the target repo's earlier positive DCO mentionContext
Multiple fix agent runs across fullsend-ai/fullsend were rejected by the post-script for including
Signed-off-bytrailers (PRs #5732, #6568, #6616, #6744), wasting agent runs. The skill-level prohibition remains as a second layer of defense.Testing
agents/code.mdandagents/fix.mdvia grephack/lint-agent-docs— all checks passCloses #552
Post-script verification
agent/552-prohibit-dco-trailers)802bbd4fcade695aa6ee12fb07ba26fdb2008979..HEAD)