Skip to content

fix(#552): add DCO sign-off prohibition to fix and code agent definitions - #1094

Open
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/552-prohibit-dco-trailers
Open

fix(#552): add DCO sign-off prohibition to fix and code agent definitions#1094
fullsend-ai-coder[bot] wants to merge 1 commit into
mainfrom
agent/552-prohibit-dco-trailers

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

  • Add explicit git commit -s / Signed-off-by prohibition to the Constraints section of both agents/fix.md and agents/code.md
  • The constraint was previously only in the skills (code-implementation/SKILL.md and fix-review/SKILL.md), which appear later in context and were sometimes overridden by the target repo's earlier positive DCO mention
  • Placing the rule in the agent definition ensures it appears early in context where the model is most likely to internalize it

Context

Multiple fix agent runs across fullsend-ai/fullsend were rejected by the post-script for including Signed-off-by trailers (PRs #5732, #6568, #6616, #6744), wasting agent runs. The skill-level prohibition remains as a second layer of defense.

Testing

  • Verified constraint text appears in both agents/code.md and agents/fix.md via grep
  • Ran hack/lint-agent-docs — all checks pass
  • Secret scan clean
  • No production code or test changes needed — this is a docs-only change to agent definitions

Closes #552

Post-script verification

  • Branch is not main/master (agent/552-prohibit-dco-trailers)
  • Secret scan passed (gitleaks — 802bbd4fcade695aa6ee12fb07ba26fdb2008979..HEAD)
  • PR body secret scan passed (gitleaks — no-git)

…ions

The prohibition against `git commit -s` and `Signed-off-by` trailers
existed only in the skills (code-implementation and fix-review), which
appear later in context and sometimes lose to the target repo's earlier
positive mention of DCO sign-off. This caused repeated post-script
rejections on multiple PRs across fullsend-ai/fullsend, wasting entire
agent runs.

Add an explicit constraint to the Constraints section of both
agents/fix.md and agents/code.md so the rule appears early in context
where the model is most likely to internalize it. The skill-level
prohibition remains as a second layer of defense.

Closes #552
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner August 31, 2026 14:11
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 31, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 2:12 PM UTC · Completed 2:25 PM UTC

Commit: fef7b7d · View workflow run →

Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $2.35

@fullsend-ai-review fullsend-ai-review Bot added the risk/moderate PR risk: moderate label Aug 31, 2026
@fullsend-ai-review

Copy link
Copy Markdown

Risk Assessment: moderate (2/5)

Details

Docs-only change with minimal surface area (6 lines, 2 files, small blast radius) to protected agent definition files; moderate risk due to multi-author contention and elevated fix/revert history in target files, but straightforward scope and complete acceptance criteria coverage reduce overall risk.

@fullsend-ai-review

Copy link
Copy Markdown

Review

Findings

Medium

@fullsend-ai-review fullsend-ai-review Bot added the requires-manual-review Review requires human judgment label Aug 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-review requires-manual-review Review requires human judgment risk/moderate PR risk: moderate

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix and code agent definitions should explicitly prohibit git commit -s and Signed-off-by trailers

0 participants