fix(#107): escalate forbidden type+scope commit violations to high severity

[fullsend-ai-coder]

The style-conventions sub-agent classified forbidden type+scope combinations (e.g. fix(ci):) as medium severity, which mapped to comment-only verdicts under the pr-review verdict logic. COMMITS.md explicitly marks these as required changes, not cosmetic.

Add a commit-format severity escalation section to the style-conventions sub-agent that classifies violations of the COMMITS.md forbidden type+scope table as high severity. High severity inherently maps to request-changes in the orchestrator step 6f verdict logic, making these violations blocking without special-casing the verdict rules.

---

Closes #107

Post-script verification

• Branch is not main/master (agent/107-escalate-commit-format-severity)
• Secret scan passed (gitleaks — 8fb64a25b70e4d364f6d535bb252c1bad521629d..HEAD)
• Pre-commit hooks passed (authoritative run on runner)
• Tests ran inside sandbox

[ralphbean]

Kicking this back to triage.

[fullsend-ai-retro]

🤖 Finished Retro · ✅ Success · Started 7:13 PM UTC · Completed 7:21 PM UTC
Commit: 776e8c4 · View workflow run →

[fullsend-ai-retro]

Retro: PR #110 — Closed without merge

PR: #110 — escalate forbidden type+scope commit violations to high severity
Issue: #107 — commit-format violations merged unaddressed
Outcome: Human reviewer (ralphbean) closed the PR without merging, redirecting to a linter-based approach.

Timeline

1. 15:32 — Retro agent creates issue Commit-format violations merged unaddressed despite COMMITS.md 'required change' language #107 from PR fix(ci): persist fullsend version and validate before use #90 retro, proposing two prompt-based solutions (verdict special case or severity escalation).
2. 15:37 — Triage agent triages Commit-format violations merged unaddressed despite COMMITS.md 'required change' language #107 as sufficient, recommends severity escalation in the style-conventions sub-agent (Option B).
3. 15:48 — Code agent creates PR fix(#107): escalate forbidden type+scope commit violations to high severity #110: adds 27 lines to skills/pr-review/sub-agents/style-conventions.md to escalate forbidden type+scope violations to high severity.
4. 19:11 — Human closes PR fix(#107): escalate forbidden type+scope commit violations to high severity #110 without merging. Comment on Commit-format violations merged unaddressed despite COMMITS.md 'required change' language #107: deterministic enforcement via a custom linter is preferred — it adds zero context to the agent window and has a 0% failure rate.
5. 19:17 — Re-triage of Commit-format violations merged unaddressed despite COMMITS.md 'required change' language #107 correctly identifies two gaps: (1) gitlint doesn't enforce forbidden type+scope combinations (primary), (2) review agent verdict gap (secondary). Recommends custom gitlint rule.
6. 19:18 — Second code agent run begins based on the corrected triage.

Key Finding

The entire pipeline (retro → triage → code) defaulted to a prompt-based solution without considering that the repo already has gitlint with custom rule support. The human had to redirect the pipeline toward a deterministic enforcement approach. After the redirect, the re-triage correctly identified the linter gap and a second code run is underway.

This is the same class of problem as #81, which documents agents defaulting to code-level solutions (mocks) when simpler infrastructure solutions (install the dependency) exist. Issue #81 is narrowly scoped to test dependencies in the retro agent. PR #110 shows the pattern is broader: the triage agent also lacks guidance to prefer deterministic enforcement (linters, CI checks) over probabilistic prompt-based enforcement.

Evidence for existing issues

• Retro proposals for test failures should consider environment-level fixes alongside code-level mocks #81 — This PR provides additional evidence that agents systematically underweight deterministic/infrastructure solutions. Retro proposals for test failures should consider environment-level fixes alongside code-level mocks #81 covers the retro agent for test dependencies; this case covers the triage agent for enforcement mechanisms.
• Commit-format violations merged unaddressed despite COMMITS.md 'required change' language #107 — The re-triage has already corrected course. A second code run is in progress with the linter approach.

Proposals filed

• Triage agent should prefer deterministic enforcement over prompt-based enforcement (in fullsend-ai/agents)