fix(#1099): resolve skillsaw CI failures - #1101
Conversation
Fix source-level violations flagged by skillsaw --strict: - content-weak-language in skills/code-implementation/SKILL.md: replace vague "properly" with specific phrasing, remove non-actionable "note that" and state the constraint directly. - content-description-routing in skills/pr-risk-assessment/SKILL.md: add "Use when" trigger phrasing to the skill description. Regenerate the skillsaw baseline to capture the current context-budget ceiling for code-implementation/SKILL.md (11,649 tokens, up from the previous 11,477 after the Jira overlay merge). The fixed violations are removed from the baseline since they no longer exist. Note: pre-commit could not run in the sandbox due to network restrictions (HTTP 403 fetching hook repos). Hooks were verified manually: trailing whitespace, end-of-file newlines, JSON validity, and merge conflict markers all pass. The post-script runs an authoritative pre-commit check. Closes #1099
3892bc0 to
758f741
Compare
|
🤖 Review · Commit: |
skillsaw --strict fails CI on content-description-routing because skills/jira-components/SKILL.md (merged in #1085) has no trigger phrasing. Match the other skills by starting the description with "Use when". Signed-off-by: Hector Martinez <hemartin@redhat.com>
ff40754 to
555cc76
Compare
|
🤖 Finished Review · ✅ Success · Started 9:21 AM UTC · Completed 9:38 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.76 |
|
Risk Assessment: moderate (2/5) DetailsSmall config-only PR by a trusted bot fixing skillsaw CI baseline and SKILL.md frontmatter across 4 files (92 lines). Protected paths raise a flag but the changes are low-complexity metadata corrections with clear issue scope, no security impact, and easy rollback. Moderate git churn on code-implementation/SKILL.md contributes minor history risk. |
ReviewFindingsMedium
Low
|
|
🤖 Finished Retro · ✅ Success · Started 10:28 AM UTC · Completed 10:39 AM UTC Commit: Runtime: claude · Model: opus → claude-opus-4-6 · Effort: high · Cost: $3.38 |
Retro: PR #1101 — fix(#1099): resolve skillsaw CI failuresWorkflow quality: Good. The code agent correctly fixed all three skillsaw violations that existed at the time it ran ($1.60). Human rework was needed only because PR #1085 merged ~3 hours later, introducing Timeline:
Review quality: The review agent posted two findings. The Existing issue corroboration:
Agents repo: Both code and review agents resolved from Proposals filed |
Summary
Fixes skillsaw CI failures that were introduced when the Jira source-code overlay PR (#1075) merged and increased the token count of
skills/code-implementation/SKILL.mdbeyond its baselined ceiling.Three changes:
skills/code-implementation/SKILL.md: Replace vague "properly" with specific phrasing; remove non-actionable "note that" and state the constraint directly. Resolvescontent-weak-languageviolations at lines 161 and 195.skills/pr-risk-assessment/SKILL.md: Add "Use when" trigger phrasing to the skill description. Resolvescontent-description-routingviolation..skillsaw-baseline.json: Regenerate baseline to capture the newcontext-budgetceiling (11,649 tokens, up from 11,477). Fixed violations are removed from the baseline.Verification
skillsaw --strict # ✓ All checks passed! (0 errors, 0 warnings, 10 suppressed by baseline)Closes #1099
Post-script verification
agent/1099-fix-skillsaw-ci)48511880eaea5ef01f80b69ba4f228147611db33..HEAD)