revert: per-agent runtime/model routing (#1209) — fleet project lacks claude-sonnet-5 - #1223
revert: per-agent runtime/model routing (#1209) — fleet project lacks claude-sonnet-5#1223waynesun09 wants to merge 1 commit into
Conversation
… claude-sonnet-5 The first fleet review after #1209 merged failed at the orchestrator's first model call: Vertex returned 404 for claude-sonnet-5 in the project the fleet runs on (fullsend-ai/fullsend#7167, run 34365183694). The sonnet alias sits on every sonnet parent and has no fallback, so review, fix, triage and retro fail on every trigger. Restore the previous config until the fleet project's served models are confirmed from CI. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
PR Summary by QodoRevert unsupported per-agent model routing
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
|
🤖 Finished Review · ❌ Failure (validation failed after 1 iteration(s)) · Started 2:55 PM UTC · Completed 2:57 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high |
Code Review by Qodo
1. Five review checks still use Sonnet
|
| - name: review | ||
| runtime: pi | ||
| model: sonnet | ||
| subagents: |
There was a problem hiding this comment.
1. Five review checks still use sonnet 🐞 Bug ≡ Correctness
Removing the review runtime and subagent overrides makes the restored Claude runner use the model declared in each native subagent manifest, where five standard checks still specify sonnet rather than inheriting opus. Whenever review dispatches the standard roster, those checks resolve through the fleet pin claude-sonnet-4-6, so the revert does not deliver its stated all-Opus routing.
Agent Prompt
## Issue description
The reverted review configuration restores the Claude/Opus parent but leaves five native review subagent manifests selecting `sonnet`. Ensure every review subagent resolves to `opus` without reintroducing the unavailable Sonnet 5 alias.
## Issue Context
Claude Code resolves each subagent's frontmatter model independently from the parent model. Add explicit local Opus overrides for the complete review roster, or update the relevant manifests and pinned remote source so none of these checks retains Sonnet routing.
## Fix Focus Areas
- .fullsend/config.yaml[15-16]
- skills/pr-review/sub-agents/intent-coherence.md[1-7]
- skills/pr-review/sub-agents/style-conventions.md[1-7]
- skills/pr-review/sub-agents/docs-currency.md[1-6]
- skills/pr-review/sub-agents/cross-repo-contracts.md[1-6]
- skills/pr-review/sub-agents/risk-assessment.md[1-7]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
|
🤖 Finished Review · ✅ Success · Started 3:03 PM UTC · Completed 3:17 PM UTC Commit: Runtime: pi · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $2.71 |
|
Risk Assessment: low (1/5) DetailsSingle-file, 28-line revert of a config change by a known non-bot human author with no protected/security-sensitive paths, no dependency or CI changes (Tier 1 composite ~1.1); Tier 2 churn/multi-author signals are moderate (~2.0) but no linked issue is present so weights redistribute to Tier1=62%/Tier2=38%, yielding a rounded composite score of 1 (low). |
ReviewFindingsMedium
Everything else checks out: this is a verified, byte-exact revert of PR #1209's changes to Next steps:
|
|
Not needed: the cause was the fleet project (prod) not serving claude-sonnet-5 / xai/grok-4.6, and those were enabled in its Model Garden on 2026-09-09. A natural fleet review then succeeded on the merged config (fullsend run 34367379698: nine personas resolved, seven persona-tagged dispatches across claude-sonnet-5, gemini-3.8-flash and xai/grok-4.6, cost $2.90). Closing without merge. |
|
🤖 Finished Retro · ✅ Success · Started 3:23 PM UTC · Completed 3:34 PM UTC Commit: Runtime: claude · Model: sonnet → claude-sonnet-5 · Effort: high · Cost: $1.73 |
|
Retro on #1223 — a human-authored revert of PR #1209's per-agent model routing, opened after the review dispatch on a downstream PR (fullsend-ai/fullsend#7167) hit a 404 because the fleet's production Vertex project didn't yet serve Proposals filed |
What
Reverts the per-agent runtime/model routing merged today (#1209), restoring the previous config: every agent on Claude Code /
opus, nomodels.aliases.Why — the fleet is failing at the first model call
First fleet review after the merge (fullsend-ai/fullsend#7167, run 34365183694): Bootstrap resolved all nine personas, then the orchestrator's first request failed:
The Vertex project the fleet runs on does not serve
claude-sonnet-5. The aliassonnet: claude-sonnet-5is on everysonnetparent (review, fix, triage, retro), and a pinned alias has no fallback, so every one of those agents fails on every trigger until this is reverted.code(Grok) andprioritize(Gemini) may or may not be served there — nothing has proven it on the fleet project, so the whole routing goes back until it is.The local validation runs were done against a project that serves all three ids; the fleet's project is a different one. That is the mistake — the served-model check must be run against the project the fleet actually uses, which is the secret
FULLSEND_GCP_PROJECT_ID, not a probe from a laptop.Re-apply plan
fullsend runfrom CI against it, or an adminrawPredictprobe from the project itself.sonneton the default alias unlessclaude-sonnet-5is enabled there.