fix(#272): remove signing from convention discovery lists

[fullsend-ai-coder]

Summary

• Remove "signing" from the convention discovery lists in fix-review/SKILL.md and code-implementation/SKILL.md so agents no longer pick up target-repo signing conventions (e.g. git commit -s)
• This eliminates the non-deterministic conflict between discovery ("learn signing conventions") and prohibition ("NEVER use git commit -s") that caused repeated post-script blocks on docs(adr): update repos-management plan to reflect all PRs merged fullsend#5273
• The existing NEVER prohibitions and post-script hard gates remain as defense-in-depth

Changes

File	Change
skills/fix-review/SKILL.md line 200	(message format, signing) → (message format)
skills/code-implementation/SKILL.md line 182	signing requirements, message format → message format

Testing

• Verified "signing" no longer appears in either skill file's discovery section
• Verified the NEVER prohibitions (NEVER use git commit -s) remain intact at lines 350 and 659 respectively
• Secret scan passed
• Existing test suite runs unchanged (pre-existing failure in post-triage-test.sh is unrelated)

---

Closes #272

Post-script verification

• Branch is not main/master (agent/272-remove-signing-discovery)
• Secret scan passed (gitleaks — 6565264dd3ce65cbf5361202aadab0047b71f015..HEAD)
• PR body secret scan passed (gitleaks — no-git)
• Pre-commit hooks passed (authoritative run on runner)
• Tests ran inside sandbox

[rh-hemartin]

This should be fixed over at fullsend-ai/agents.

[fullsend-ai-retro]

🤖 Finished Retro · ✅ Success · Started 6:11 AM UTC · Completed 6:23 AM UTC
Commit: bdedf71 · View workflow run →

[fullsend-ai-retro]

Retro: PR #273 — Remove signing from convention discovery lists

Outcome: PR was erroneously closed without merging. The underlying fix (issue #272) is still needed and should be re-attempted.

Timeline

Time (UTC)	Event
2026-07-18 01:24	Issue #272 filed — fix agent repeatedly fails with Signed-off-by post-script blocks
2026-07-18 01:24–01:28	Triage agent (run 29625126807) confirms root cause, labels ready-to-code
2026-07-18 01:28–01:34	Code agent (run 29625259693) creates PR #273 with a correct 2-line fix
2026-07-20 06:09	Human reviewer closes PR without merging, commenting "This should be fixed over at fullsend-ai/agents"

Agent performance

• Triage: Excellent. Confirmed root cause against codebase, recommended specific fix with line numbers, applied correct labels. 4 minutes.
• Code: Excellent. Minimal, precise 2-line change matching the triage recommendation exactly. Post-script verification passed. 6 minutes total.
• Review: Did not run. Code agent logged "Failed to apply ready-for-review label to PR fix(#272): remove signing from convention discovery lists #273," likely preventing review dispatch.

What went wrong

The PR was closed by a human reviewer whose comment suggests repo-context confusion — the PR was already on fullsend-ai/agents, which is exactly where the fix belongs. No automated or human review was submitted before closure. Contributing factors: (1) the ready-for-review label failure prevented automated review, leaving no approval signal for the human; (2) the PR body's first bullet referenced fullsend-ai/fullsend#5273 as motivation, potentially priming the reviewer to associate the PR with a different repo.

Self-healing status

Issue #272 remains open and labeled ready-to-code. Both skill files still contain "signing" in their convention discovery sections (confirmed on main). The code agent should re-attempt the fix automatically.

Existing issue coverage

No novel proposals filed for these — the gaps are already tracked:

• agents#272 — the underlying signing fix. Open, ready-to-code.
• agents#274 — ready-for-review label application failure that prevented automated review.
• fullsend#2975 — prompting maintainers when closing PRs without feedback. This retro provides supporting evidence: a clarifying prompt might have surfaced the repo confusion before the erroneous closure.
• fullsend#3818 — removing ready-to-code when a PR is rejected. Caution from this case: not all closures are intentional rejections. Implementing #3818 naively here would remove ready-to-code from Fix agent repeatedly fails with Signed-off-by post-script block on PR #5273 #272 and break the self-healing mechanism. The implementation should distinguish intentional rejection from erroneous closure.

Proposals filed

• Code agent PR summary should lead with local file changes, not cross-repo references (in fullsend-ai/agents)