fix(#537): add remediation consistency rule to correctness sub-agent - #538
Open
fullsend-ai-coder[bot] wants to merge 1 commit into
Open
fix(#537): add remediation consistency rule to correctness sub-agent#538fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add guidance to the correctness sub-agent definition preventing it from suggesting remediations that contradict its own analysis. When a severity rationale acknowledges a prior state is broken, the agent must not suggest falling back to that broken state. When a companion PR provides the missing piece, the agent should frame remediation around merge coordination instead. The rule is placed under the "Runtime mechanism checklist" section in correctness.md, after the failure-paths bullet, where the agent evaluates cross-component contracts and API findings. Note: pre-commit could not run in sandbox (network restriction). The post-script runs it authoritatively on the runner. Closes #537
|
🤖 Finished Review · ✅ Success · Started 9:56 PM UTC · Completed 10:07 PM UTC |
ReviewFindingsMedium
Labels: PR modifies review agent sub-agent definition (skills/pr-review/sub-agents/correctness.md) |
fullsend-ai-review
Bot
added
requires-manual-review
|
This pull request has been automatically marked as stale because it has not had any activity in the last month. It will be closed in 2 weeks if no further activity occurs. Remove the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
skills/pr-review/sub-agents/correctness.md)Context
On PR #527, the correctness sub-agent repeatedly raised an
[api-contract]finding where it downgraded severity because a prior approach was "already broken," then simultaneously suggested falling back to that broken approach. This contradiction required 8+ human dismissals. The root cause was missing self-consistency guidance between severity rationale and remediation suggestions.Changes
The new rule is placed under the "Runtime mechanism checklist" section, after the existing failure-paths bullet. This location is appropriate because
api-contractfindings are in the correctness sub-agent's domain, and the runtime mechanism checklist is where it evaluates cross-component contracts.Testing
Closes #537
Post-script verification
agent/537-remediation-consistency-rule)5e45ff31e2ccc1c69f0126f2f690aaef8e9712df..HEAD)