docs(autonomy-readiness): tighten weak language in skill - #747
Conversation
Ran skillsaw (evaluating it per #188) against the repo's skills. Replaces vague/hedging phrasing with direct instructions: "handle silent approvals correctly" -> "classify silent approvals as inconclusive", and "consider adding new agent skills" -> "propose new agent skills ... when a human reviewer consistently catches a class of issue". Related to #188 Assisted-by: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Ralph Bean <rbean@redhat.com>
PR Summary by QodoTighten autonomy-readiness skill guidance for silent approvals and new skills
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
|
🤖 Finished Review · ✅ Success · Started 5:00 PM UTC · Completed 5:09 PM UTC Commit: |
Code Review by Qodo
1. Protected skills/ file modified
|
ReviewFindingsMedium
Labels: PR modifies skill documentation in skills/ directory |
waynesun09
left a comment
There was a problem hiding this comment.
Approving — no blocking issues. The qodo protected-path note is satisfied by this approval itself. My own MEDIUM (skill-proposal trigger narrowing) is a non-blocking semantic nuance, not a defect. CI green.
|
🤖 Finished Retro · ✅ Success · Started 9:40 PM UTC · Completed 9:52 PM UTC Commit: |
Retro: PR #747 — docs(autonomy-readiness): tighten weak language in skillTimeline
Key finding: intent-coherence sub-agent's exploration budget prevented detection of semantic narrowingThe human reviewer's core insight was that the rewording changed meaning, not just tone. The original text contained an unconditional recommendation ("consider adding new agent skills") plus a conditional emphasis ("If a human reviewer consistently catches..."). The rewrite merged these into a single conditional ("propose new agent skills... when a human reviewer consistently catches..."), which reads as the sole trigger for skill proposals — contradicting the paragraph above. The intent-coherence sub-agent is the natural owner of this class of issue (intent alignment, scope changes), but its exploration budget classifies diffs under 20 lines as trivial: 5 tool calls max, read only the diff and linked issue, then STOP. For this 4-line diff, the sub-agent would not have read the surrounding paragraphs of SKILL.md or detected the intra-document tension. The non-trivial path (20+ lines or structural changes) reads CLAUDE.md, AGENTS.md, and ADRs — but a small wording change to a skill file doesn't trigger it. The correctness sub-agent (Opus, 15-call budget) had more room to explore but explicitly concluded the changes were "semantically equivalent" — either it also didn't read enough surrounding context, or it failed to recognize the scope narrowing. Evidence for existing issues
Proposals filed |
Ran skillsaw (evaluating it per #188) against the repo's skills.
Replaces vague/hedging phrasing with direct instructions: "handle
silent approvals correctly" -> "classify silent approvals as
inconclusive", and "consider adding new agent skills" -> "propose
new agent skills ... when a human reviewer consistently catches a
class of issue".
Related to #188
Assisted-by: Claude Opus 4.6 noreply@anthropic.com
Signed-off-by: Ralph Bean rbean@redhat.com
Stack created with GitHub Stacks CLI • Give Feedback 💬