fix(#880): rename github-artifacts credential key to avoid collision - #881
Closed
fullsend-ai-coder[bot] wants to merge 1 commit into
Closed
fix(#880): rename github-artifacts credential key to avoid collision#881fullsend-ai-coder[bot] wants to merge 1 commit into
fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
The retro agent sandbox creation fails because both github-ro and
github-artifacts providers declare GH_TOKEN as their credential key.
OpenShell rejects sandboxes where two providers inject the same
credential env key.
Rename the credential key in github-artifacts from GH_TOKEN to
GH_TOKEN_ARTIFACTS. The underlying secret value (${GH_TOKEN}) is
unchanged — only the key name the proxy uses to track the credential
is different. The gh CLI still receives GH_TOKEN via the harness
forge.github.env.sandbox block, so CLI functionality is preserved.
Note: pre-commit could not run (sandbox network policy blocked
git fetch during hook environment setup). The post-script runs
pre-commit authoritatively on the runner.
Closes #880
Contributor
|
This won't work correctly gh uses gh_token env var, no the renamed one, I'm working on a better woraround. Closing. |
|
🤖 Finished Review · ✅ Success · Started 1:17 PM UTC · Completed 1:28 PM UTC Commit: |
|
Review skipped — this PR is already closed. The Posted by fullsend pre-review check |
|
🤖 Finished Retro · ❌ Failure · Started 1:18 PM UTC · Completed 1:19 PM UTC Commit: |
|
Review skipped — this PR is already closed. The Posted by fullsend post-review check |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
providers/github-artifacts.yamlfromGH_TOKENtoGH_TOKEN_ARTIFACTSto eliminate the duplicate credential key collision that prevents the retro agent sandbox from being created.${GH_TOKEN}) is unchanged — only the key name that OpenShell's proxy uses to track the credential is different.ghCLI still receivesGH_TOKENvia the harnessforge.github.env.sandboxblock, so CLI functionality is preserved.Context
Introduced in #211 (refactor: migrate to local-path providers and profiles). The retro agent is the only agent attaching two GitHub providers (
github-ro+github-artifacts), so it was the only one triggering the conflict. This fix also prevents the same collision for any future harness that combines multiple GitHub providers.Testing
github-artifacts.yamlcredentials by key name.make test— all test suites pass (10 pre-existing failures inpost-retro-test.share unrelated to this change and exist onmain).Closes #880
Post-script verification
agent/880-fix-duplicate-credential-key)816b89be3a8d129cb9305ae492d4af145d6ac25a..HEAD)