fix(workflows): use fully-qualified paths in reusable-dispatch stage jobs - #1971
Conversation
Site previewPreview: https://7f8d7438-site.fullsend-ai.workers.dev Commit: |
…jobs
Relative (./) paths in uses: resolve against the caller's repo, not the
repo that defines the reusable workflow. This breaks per-repo mode where
the caller is an external repo without the reusable-{stage}.yml files.
Restore fully-qualified fullsend-ai/fullsend/...@v0 references and add
a regression test to prevent re-introduction.
Signed-off-by: Wayne Sun <gsun@redhat.com>
33b814d to
eb5dc3e
Compare
|
Review skipped — this PR is already merged. The Posted by fullsend post-review check |
Retro: PR #1971 — fix(workflows): use fully-qualified paths in reusable-dispatch stage jobsWhat happened: PR #1278 changed reusable workflow The critical review failure on PR #1278: The review squad (7-agent ensemble) actually flagged the relative-path regression — at least one agent identified that relative Review on PR #1971: The review agent completed its analysis (~8 min) but the PR was merged ~33 seconds before the post-script ran, so results were discarded. This race condition is already tracked by multiple open issues (#885, #1373, #1439, #1870). Proposals: 1 new proposal. Skipped 2 proposals due to existing issue coverage: workflow_call chain tracing (#1275) and merged-PR review race (#885, #1373, #1439, #1870). Proposals filed
|
Summary
uses:paths (fullsend-ai/fullsend/.github/workflows/reusable-{stage}.yml@v0) inreusable-dispatch.yml, replacing relative./paths introduced in feat(workflows): add fullsend_ai_ref for self-consistent version pinning #1278TestReusableDispatchUsesFullyQualifiedPathsregression test to prevent re-introductionProblem
PR #1278 changed the
uses:lines inreusable-dispatch.ymlfrom fully-qualified to relative (./) paths. Relative paths inuses:resolve against the caller's repository, not the repo that defines the reusable workflow. In per-repo mode, the caller is an external repo (e.g.,konflux-ci/operator-foundry) that doesn't have thereusable-{stage}.ymlfiles, so GitHub Actions fails instantly with "workflow was not found" before any jobs run.First observed on
konflux-ci/operator-foundryrun 27046721150 after the v0 tag was moved to include the change.Test plan
go test -run TestWorkflowCallInputAlignment— existing alignment test passesgo test -run TestReusableDispatchUsesFullyQualifiedPaths— new regression test passesgo test ./...ininternal/scaffold— full suite passes/fs-reviewonkonflux-ci/operator-foundryPR docs: Add codebase context problem document and trim CLAUDE.md #3