Skip to content

fix(workflows): use fully-qualified paths in reusable-dispatch stage jobs - #1971

Merged
waynesun09 merged 1 commit into
mainfrom
fix-per-repo-dispatch-paths
Jun 6, 2026
Merged

fix(workflows): use fully-qualified paths in reusable-dispatch stage jobs#1971
waynesun09 merged 1 commit into
mainfrom
fix-per-repo-dispatch-paths

Conversation

@waynesun09

Copy link
Copy Markdown
Member

Summary

Problem

PR #1278 changed the uses: lines in reusable-dispatch.yml from fully-qualified to relative (./) paths. Relative paths in uses: resolve against the caller's repository, not the repo that defines the reusable workflow. In per-repo mode, the caller is an external repo (e.g., konflux-ci/operator-foundry) that doesn't have the reusable-{stage}.yml files, so GitHub Actions fails instantly with "workflow was not found" before any jobs run.

First observed on konflux-ci/operator-foundry run 27046721150 after the v0 tag was moved to include the change.

Test plan

  • go test -run TestWorkflowCallInputAlignment — existing alignment test passes
  • go test -run TestReusableDispatchUsesFullyQualifiedPaths — new regression test passes
  • go test ./... in internal/scaffold — full suite passes
  • After v0 tag is moved: re-trigger /fs-review on konflux-ci/operator-foundry PR docs: Add codebase context problem document and trim CLAUDE.md #3

@github-actions

github-actions Bot commented Jun 6, 2026

Copy link
Copy Markdown

Site preview

Preview: https://7f8d7438-site.fullsend-ai.workers.dev

Commit: eb5dc3e0bfd8ec564c23d22aa1f361426056ba11

…jobs

Relative (./) paths in uses: resolve against the caller's repo, not the
repo that defines the reusable workflow. This breaks per-repo mode where
the caller is an external repo without the reusable-{stage}.yml files.

Restore fully-qualified fullsend-ai/fullsend/...@v0 references and add
a regression test to prevent re-introduction.

Signed-off-by: Wayne Sun <gsun@redhat.com>
@waynesun09
waynesun09 force-pushed the fix-per-repo-dispatch-paths branch from 33b814d to eb5dc3e Compare June 6, 2026 00:54
@waynesun09
waynesun09 added this pull request to the merge queue Jun 6, 2026
Merged via the queue into main with commit ee04a59 Jun 6, 2026
7 of 8 checks passed
@waynesun09
waynesun09 deleted the fix-per-repo-dispatch-paths branch June 6, 2026 01:03
@fullsend-ai-review

Copy link
Copy Markdown

Review skipped — this PR is already merged.

The /fs-review command only reviews open pull requests.

Posted by fullsend post-review check

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #1971 — fix(workflows): use fully-qualified paths in reusable-dispatch stage jobs

What happened: PR #1278 changed reusable workflow uses: lines from fully-qualified paths (fullsend-ai/fullsend/.github/workflows/reusable-code.yml@v0) to relative paths (./.github/workflows/reusable-code.yml). This broke per-repo mode because relative uses: in workflow_call resolves against the caller's repository, not the repo defining the reusable workflow. External repos (e.g., konflux-ci/operator-foundry) don't have those files. PR #1971 reverted the paths and added a regression test.

The critical review failure on PR #1278: The review squad (7-agent ensemble) actually flagged the relative-path regression — at least one agent identified that relative ./ workflow paths break cross-repo calls. However, the synthesis step dismissed it as a false positive with the incorrect justification: "GitHub resolves relative workflow_call paths within the called workflow's repository at the same ref. The design is correct." This conflated composite action resolution (which works locally) with reusable workflow resolution (which resolves against the caller). Neither human reviewers nor the challenger pass caught this error.

Review on PR #1971: The review agent completed its analysis (~8 min) but the PR was merged ~33 seconds before the post-script ran, so results were discarded. This race condition is already tracked by multiple open issues (#885, #1373, #1439, #1870).

Proposals: 1 new proposal. Skipped 2 proposals due to existing issue coverage: workflow_call chain tracing (#1275) and merged-PR review race (#885, #1373, #1439, #1870).

Proposals filed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant