feat(#2611): pin runners to ubuntu-24.04 with configurable __GH_RUNNER__ - #2659
Conversation
PR Summary by QodoPin GitHub Actions runners to ubuntu-24.04 Description
Diagram
High-Level Assessment
Files changed (27)
|
Site previewPreview: https://71e98ced-site.fullsend-ai.workers.dev Commit: |
|
🤖 Finished Review · ✅ Success · Started 2:21 PM UTC · Completed 2:34 PM UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Code Review by Qodo
1. Docs still show ubuntu-latest
|
ReviewFindingsMedium
Labels: PR modifies CI workflows and scaffold templates for runner pinning Previous runReviewFindingsMedium
Labels: PR modifies CI workflows and scaffold templates for runner pinning Previous runReviewFindingsMedium
Labels: PR pins GitHub Actions runner versions across CI workflows and scaffold templates — CI maintenance. Labels: PR modifies CI workflows, scaffold templates, and runner configuration Previous runReviewFindingsMedium
Labels: PR modifies CI workflows and scaffold templates for runner pinning Previous run (2)ReviewFindingsMedium
Labels: PR pins GitHub Actions runner versions across CI workflows and scaffold templates — CI maintenance. |
Replace ubuntu-latest with ubuntu-24.04 across all repo CI workflows and the custom agents user guide. Pinning prevents silent breakage when GitHub updates the ubuntu-latest alias. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
eec8999 to
eed2d71
Compare
|
🤖 Review · |
Add DefaultGHRunner constant ("ubuntu-24.04") in config and wire
__GH_RUNNER__ placeholder substitution through the scaffold render
pipeline. All scaffold templates now use __GH_RUNNER__ instead of a
hardcoded runner, resolved to the default at install time. Callers
can override via RenderOptions.RunnerImage.
Assisted-by: Claude
Signed-off-by: Wayne Sun <gsun@redhat.com>
eed2d71 to
4bf6085
Compare
|
🤖 Finished Review · ✅ Success · Started 2:46 PM UTC · Completed 3:00 PM UTC |
Add runner_image workflow_call input (default: ubuntu-24.04) to all reusable agent workflows and reusable-dispatch.yml. The dispatch workflow passes the value through to each stage. Callers can now override the runner image without forking workflows. Assisted-by: Claude Signed-off-by: Wayne Sun <gsun@redhat.com>
4bf6085 to
b0f9080
Compare
|
🤖 Finished Review · ✅ Success · Started 3:12 PM UTC · Completed 3:25 PM UTC |
|
🤖 Finished Retro · ✅ Success · Started 7:42 PM UTC · Completed 7:50 PM UTC |
Retro: PR #2659 — Pin runners to ubuntu-24.04 with configurable
|
Summary
runs-on: ubuntu-latesttoubuntu-24.04across repo CI workflows and user-facing docs__GH_RUNNER__placeholder, resolved at install time fromconfig.DefaultGHRunnerrunner_imageinput (default:ubuntu-24.04) to all reusable workflows so callers can overrideArchitecture
.github/workflows/)ubuntu-24.04internal/scaffold/)__GH_RUNNER__placeholder, resolved byrender.goRunnerImageinRenderOptionsreusable-*.yml)runner_imageinput with defaultrunner_imageinwith:Commits
ubuntu-24.04DefaultGHRunnerconstant, wire__GH_RUNNER__through render pipeline, update templates and testsrunner_imageinput to all reusable workflows, pass through dispatchCloses #2611
Test plan
grep -r 'ubuntu-latest' .github/workflows/ internal/scaffold/returns nothinggo test ./internal/scaffold/ ./internal/config/passesmake lintpassesubuntu-24.04