docs(custom): add PATH modification example - #2882
Conversation
PR Summary by QodoDocument how to modify PATH for custom tools via host_files
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
|
🤖 Finished Review · ✅ Success · Started 6:46 AM UTC · Completed 6:57 AM UTC |
|
cc @ralphbean as stated in the docs |
Site previewPreview: https://7cf3db48-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Code Review by Qodo
1.
|
ReviewVerdict: Approve Docs-only PR adding a well-structured section on custom executables and PATH modification to
The prior review's four low-severity findings (technical-accuracy on "rejects" wording, unnecessary No findings across correctness, security, intent/coherence, style, or docs-currency dimensions. Previous runReviewFindingsLow
Previous runReviewFindingsLow
Previous run (2)ReviewFindingsMedium
Labels: Docs-only PR documenting harness host_files and env.sandbox behavior for PATH customization. |
waynesun09
left a comment
There was a problem hiding this comment.
Review squad pass (Claude + Claude + Gemini, 3 agents). All findings verified against internal/cli/run.go on main. 3 MEDIUM findings not already covered by qodo's existing comments on this PR — mostly about the doc teaching a more complex PATH-modification pattern than the built-in /sandbox/workspace/bin mechanism, plus one inaccurate explanation of expand: false.
82f560a to
2187a81
Compare
|
🤖 Review · |
2187a81 to
e1c668c
Compare
|
🤖 Review · |
e1c668c to
ffbf577
Compare
|
🤖 Review · |
ffbf577 to
99d7fc9
Compare
|
🤖 Finished Review · ✅ Success · Started 2:45 PM UTC · Completed 2:58 PM UTC |
Lead with /sandbox/workspace/bin (pre-created, already on PATH) for simple cases. Document .env.d pattern as advanced option for external toolchains. Fix expand: false explanation, note auto-chmod is temporary (#345), and clarify that only *.env files are sourced from .env.d/. Signed-off-by: Hector Martinez <hemartin@redhat.com> Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com> Signed-off-by: Hector Martinez <hemartin@redhat.com>
99d7fc9 to
1808158
Compare
|
🤖 Finished Review · ✅ Success · Started 7:22 AM UTC · Completed 7:28 AM UTC |
|
🤖 Finished Retro · ✅ Success · Started 8:04 AM UTC · Completed 8:13 AM UTC |
|
PR #2882 was a docs-only change adding a section on modifying the PATH for custom executables in the sandbox. The review agent initially approved on July 2 with zero findings, but missed three significant issues later caught by Qodo (automated, July 2) and human reviewer waynesun09 (July 13, 11 days later): (1) the docs taught a complex two-file Proposals filed
Evidence notes (not filed as issues)
|
Closes #2883