fix(#4060): reduce sub-agent dispatch for mechanical dep bumps - #4061
fix(#4060): reduce sub-agent dispatch for mechanical dep bumps#4061fullsend-ai-coder[bot] wants to merge 1 commit into
Conversation
Add a dispatch examples table row for dependency version bumps (lockfile + manifest only) that dispatches only the always-included sub-agents (correctness + style-conventions). Add a cross-reference from section 3c (dispatch) to section 3e (scope constraints) so that when triage classifies a change as "mechanical/value-only", the orchestrator suppresses conditional triggers (security, intent-coherence, docs-currency, cross-repo-contracts) and dispatches only the always-included sub-agents. Closes #4060
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
/fs-fix no, coupling review and triage this way is an architectural violation. The review agent should never suppress security analysis (or do anything really) because of something that it appears the triage agent decided. That's a recipe for future cascading attack vectors. This could be revised to provide the same logic on different conditions: look at the files changed, or by a cursory scan of the diff - if it appears to really be a mechanical change, then perhaps. If in question, err on the safe side and launch deeper review. |
|
Oh, and, in any case - we don't want to accept new changes to Closing this. |
|
🤖 Finished Fix · ✅ Success · Started 7:09 PM UTC · Completed 7:17 PM UTC |
|
🤖 Finished Retro · ✅ Success · Started 7:11 PM UTC · Completed 7:21 PM UTC |
🔧 Fix agent — iteration 1 (human-triggered)Addressed 1 human review finding: decoupled mechanical-change dispatch reduction from triage-agent classification. The review orchestrator now makes its own independent assessment based on file list and diff inspection, with a conservative default (full dispatch including security when uncertain). Fixed (1):
Tests: passed Updated by fullsend fix agent |
Replace triage-coupled dispatch override in section 3c with independent mechanical-change assessment. The review orchestrator now inspects the changed file list and diff directly, rather than relying on triage-agent classification, to determine if a change is purely mechanical. Key changes: - Remove reference to triage classification from dispatch logic - Add explicit three-condition test for mechanical changes - Require conservative dispatch (including security) when uncertain - Preserve dispatch reduction as an option only when all conditions hold Addresses review feedback on #4061
|
PR #4061 was a code-agent PR that modified This is the 4th documented occurrence of agents editing scaffold files that have migrated to The underlying retro observation (dep bumps dispatch too many sub-agents) is valid. The human's Proposals filed
|
1 participant
Add a dispatch examples table row for dependency version bumps (lockfile + manifest only) that dispatches only the always-included sub-agents (correctness + style-conventions).
Add a cross-reference from section 3c (dispatch) to section 3e (scope constraints) so that when triage classifies a change as "mechanical/value-only", the orchestrator suppresses conditional triggers (security, intent-coherence, docs-currency, cross-repo-contracts) and dispatches only the always-included sub-agents.
Closes #4060
Post-script verification
agent/4060-reduce-dispatch-dep-bumps)4cb864299807fde398b226a0f21819d942fb9415..HEAD)