docs: Clean up bits around GH Agentic Workflows - #5199
Conversation
Several docs (landscape.md, platform-nativeness.md) cited a GitHub blog post's "developers will always own the merge button" line as though it were an enforced product/platform constraint. It isn't: GitHub Apps and bot accounts can call the merge API with write access today, and GitHub's own auto-merge and merge queue features already merge PRs without a human clicking anything. The blog post is one team's editorial stance, not something the platform technically enforces. Reword the four spots making this claim to distinguish the stated position from an actual restriction, so the comparison with gh-aw doesn't overstate why it stops short of autonomous merge. Assisted-by: https://github.com/cgwalters/cgwalters#llms Signed-off-by: Colin Walters <walters@verbum.org>
|
Thank you for your interest in contributing to fullsend, @cgwalters. This project uses a vouch system for first-time contributors. Before submitting a pull request, you need to be vouched by a maintainer. To get vouched:
See CONTRIBUTING.md for details. |
E2E tests did not runE2E tests run automatically for org/repo members and collaborators on pull requests. For other contributors, a maintainer must add the See E2E testing guide for details. |
PR Summary by QodoDocs: clarify GitHub “merge button” stance vs platform enforcement (gh-aw)
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
Code Review by Qodo
1. Overbroad merge feasibility claim
|
| - **Is the forge abstraction worth the cost at this stage?** Fullsend's only concrete implementation is GitHub. If forge-neutrality is deferred to the [Infrastructure](../roadmap.md#infrastructure) and [Cross-forge orchestration](../roadmap.md#cross-forge-orchestration) work in the [roadmap](../roadmap.md), the current implementation could use GitHub-native primitives directly, simplifying the stack substantially. | ||
|
|
||
| - **Can gh-aw's safe-outputs model be extended for autonomous merge?** If a safe-output type of "merge this PR" were added (gated by all required checks passing and a confidence threshold), gh-aw's architecture could support tiered autonomy without fullsend's external plumbing. This depends on GitHub's willingness to add such a capability — which their current position suggests is unlikely. | ||
| - **Can gh-aw's safe-outputs model be extended for autonomous merge?** Nothing technical blocks this today — a plain workflow job triggered on `pull_request_review` (approved) or a passing check suite can call the merge REST endpoint or the merge-queue GraphQL mutation with a token that has write access, entirely outside gh-aw's safe-outputs system. The open question is whether gh-aw's maintainers formalize this as an official safe-output type (gated by required checks and a confidence threshold), which would make it a first-class, auditable primitive instead of something every adopter bolts on themselves. Given their stated editorial position, that seems unlikely to come from upstream — but it doesn't stop fullsend or anyone else from building it as an unofficial follow-up job today. |
There was a problem hiding this comment.
1. Overbroad merge feasibility claim 🐞 Bug ≡ Correctness
docs/problems/platform-nativeness.md states “Nothing technical blocks” autonomous merging via a standalone workflow calling merge APIs, but merges still depend on workflow token permissions plus branch protection/rulesets (required checks, required reviews, merge queue prerequisites). This can mislead readers into assuming an approval/check event alone is sufficient or that protections can be bypassed.
Agent Prompt
## Issue description
The doc uses an absolute statement ("Nothing technical blocks") when the described approach only works if repository policy and token permissions allow it (branch protection/rulesets, required checks/reviews, merge-queue configuration, workflow permissions). This should be qualified to avoid implying merges can bypass protections.
## Issue Context
This section is used to reason about whether gh-aw’s limitations are design choices vs. platform constraints. Overstating feasibility can send implementers down an incorrect path or create confusion when automation fails under common protections.
## Fix Focus Areas
- docs/problems/platform-nativeness.md[136-136]
## Suggested change
Reword to something like: “GitHub exposes APIs for programmatic merging, but success is still subject to the workflow token’s permissions and repository rules/branch protections (required checks/reviews, rulesets, merge queue prerequisites).”
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
| GA since April 2025. 1 million users in one month. Assign Copilot as a reviewer like any teammate. October 2025 update added context gathering — reads source files, explores directory structure, integrates CodeQL and ESLint. | ||
|
|
||
| **Relevance to fullsend:** GitHub's explicit "humans own the merge button" position means we cannot rely on GitHub's native tooling for autonomous merging. We'll need to build merge authority outside of (or on top of) GitHub's review/approval system. | ||
| Very relevant to fullsend: has code review and also supports having background agents steered interactively. Backend infrastructure here is reused by GitHub Agentic Workflows (see below). |
There was a problem hiding this comment.
2. Uncited infrastructure reuse claim 🐞 Bug ⚙ Maintainability
docs/landscape.md asserts that GitHub Copilot “backend infrastructure” is reused by GitHub Agentic Workflows, but provides no citation and the terms are ambiguous (what components, what kind of reuse). This reads as a factual dependency claim without support.
Agent Prompt
## Issue description
The doc makes a concrete factual claim about shared infrastructure between Copilot and gh-aw, but does not cite a source and is vague about what is shared.
## Issue Context
Landscape docs are used as a reference; ambiguous/uncited claims are hard to validate and easy to contest later.
## Fix Focus Areas
- docs/landscape.md[84-84]
## Suggested change
Either (a) add an authoritative citation supporting the reuse claim, and/or (b) rephrase to be specific and qualified (e.g., “gh-aw appears to build on similar agent runtime primitives as Copilot, based on <source>”).
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Several docs (landscape.md, platform-nativeness.md) cited a GitHub blog post's "developers will always own the merge button" line as though it were an enforced product/platform constraint. It isn't: GitHub Apps and bot accounts can call the merge API with write access today, and GitHub's own auto-merge and merge queue features already merge PRs without a human clicking anything. The blog post is one team's editorial stance, not something the platform technically enforces.
Reword the four spots making this claim to distinguish the stated position from an actual restriction, so the comparison with gh-aw doesn't overstate why it stops short of autonomous merge.
Assisted-by: https://github.com/cgwalters/cgwalters#llms