docs(e2e): document behaviour pool mint enroll for test-repo-01..12

[ifireball]

Summary

• Documents the nested hosted-mint enrollment loop for halfsend-{01..12}/test-repo (admin e2e) and test-repo-01…12 (behaviour pool), including the no-fork rule and that GitHub repos need not exist yet.
• Updates the mint-administration cross-ref to match.
• Ops enrollment on it-gcp-konflux-dev-fullsend was completed out-of-band for ops(e2e): mint-enroll behaviour pool repos test-repo-01..12 on halfsend orgs #5437 (144 numbered + 12 singular names in PER_REPO_WIF_REPOS).

Closes #5437

Related Issue

#5437 (part of #3454)

Changes

• docs/guides/dev/e2e-testing.md: nested enroll runbook
• docs/guides/infrastructure/mint-administration.md: behaviour pool enroll note

Testing

• Hosted mint verify: all halfsend-NN/test-repo-01…12 present; singular test-repo retained; no *-fork entries from this work
• make lint on staged docs

Checklist

• DCO sign-off
• Conventional commit / PR title

Made with Cursor

[qodo-code-review]

PR Summary by Qodo

Docs: document behaviour pool mint enrollment for test-repo-01..12

📝 Documentation 🕐 10-20 Minutes

AI Description

• Document nested hosted-mint enrollment for admin e2e and behaviour pool repos.
• Clarify repo naming rules (no forks) and that repos need not exist yet.
• Align mint-administration guidance with the updated e2e runbook cross-reference.

Diagram

graph TD
  A["GCP admin"] --> B["e2e-testing.md"] --> C["nested enroll loop"] --> D[("Hosted mint project")] --> E["PER_REPO_WIF_REPOS allowlist"]
  B --> F["mint-administration.md"]
  C --> G["Repo names: test-repo + test-repo-01..12"] --> H["Rule: no '*-fork'"]

Loading

High-Level Assessment

The PR’s approach (tightening the runbook and cross-references) is the right fit: it documents an operational prerequisite and naming constraints without changing behaviour. Alternatives like adding automation or validation belong in product/code changes, not in this documentation-only PR.

Files changed (2) +11 / -4

Documentation (2) +11 / -4

e2e-testing.mdDocument behaviour pool naming and nested mint enrollment loop +10/-3

Document behaviour pool naming and nested mint enrollment loop

• Clarifies that behaviour tests require pre-enrollment of pool org repos on the hosted mint and that CI does not run enroll. Adds explicit naming guidance for parallel behaviour repos ('test-repo-01..12'), the no-fork enrollment rule, and notes repos need not exist before allowlisting. Updates the example enrollment snippet to include a nested loop covering both admin and behaviour pool names.

docs/guides/dev/e2e-testing.md

mint-administration.mdAlign mint administration guidance with behaviour pool enrollment requirements +1/-1

Align mint administration guidance with behaviour pool enrollment requirements

• Updates the behaviour/e2e pool org section to explicitly include both the singular admin 'test-repo' and the 'test-repo-01..12' behaviour pool repos. Adds an explicit reminder to avoid enrolling '*-fork' names and points readers to the updated e2e testing guide section.

docs/guides/infrastructure/mint-administration.md

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 9:42 AM UTC · Completed 9:56 AM UTC
Commit: f8aed41 · View workflow run →

[github-actions]

Site preview

Preview: https://ce2c9444-site.fullsend-ai.workers.dev

Commit: 13d1fbea6560ea39e5b35611db010f1e3fa525e0

[qodo-code-review]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📜 Skill insights (1)

Context used

✅ Compliance rules (platform): 54 rules

✅ Skills: writing-user-docs, writing-adrs

1. Behaviour repo names inconsistent ✓ Resolved 🐞 Bug ≡ Correctness

Description

The updated e2e-testing runbook instructs enrolling halfsend-NN/test-repo-01…test-repo-12 for
behaviour tests, but the behaviour per-repo install driver in this repo hard-codes the repo name to
test-repo and provisions inference for <org>/test-repo. This makes the docs internally
inconsistent and can mislead operators about which repository names must actually be enrolled in
PER_REPO_WIF_REPOS.

Code

docs/guides/dev/e2e-testing.md[R89-99]

+One-time enrollment for all pool orgs (idempotent). Enroll the singular admin `test-repo` and the behaviour pool `test-repo-01` … `test-repo-12`:

```bash
export GCP_PROJECT=it-gcp-konflux-dev-fullsend
for i in $(seq -w 1 12); do
-  fullsend mint enroll "halfsend-${i}/test-repo" --project="$GCP_PROJECT" --region=us-central1
+  fullsend mint enroll "halfsend-${i}/test-repo" \
+    --project="$GCP_PROJECT" --region=us-central1
+  for j in $(seq -w 1 12); do
+    fullsend mint enroll "halfsend-${i}/test-repo-${j}" \
+      --project="$GCP_PROJECT" --region=us-central1
+  done

Relevance

⭐⭐ Medium

Teams sometimes accept doc/code consistency fixes (PR #2743, #5273), but other doc-consistency notes
were rejected (#665).

PR-#2743
PR-#5273
PR-#665

ⓘ Recommendations generated based on similar findings in past PRs

Evidence

The new docs introduce test-repo-01..12 enrolment guidance, but the behaviour test install driver
currently installs only into <org>/test-repo (hard-coded). Another existing guide also states
behaviour triage workflows operate on the pool org's test-repo, reinforcing that the current
behaviour path is test-repo, not test-repo-01..12.

docs/guides/dev/e2e-testing.md[74-103]
docs/guides/infrastructure/mint-administration.md[73-76]
pkg/behaviourtest/drivers/install/perrepo_github.go[17-88]
docs/guides/dev/behaviour-testing.md[82-83]

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
`docs/guides/dev/e2e-testing.md` now documents a behaviour repo pool `test-repo-01`…`test-repo-12` and adds a nested `mint enroll` loop for those repos. In the current codebase, the behaviour per-repo install driver uses the fixed repo name `test-repo`, so the new docs conflict with the implementation and with other docs that still describe `test-repo`.

## Issue Context
The behaviour per-repo driver is selected when `BEHAVIOUR_INSTALL_MODE=per-repo` and currently always installs into `<org>/test-repo`. If the behaviour pool is intended to move to `test-repo-01..12`, the driver (and any provisioning/inference calls) need to be updated to select those repo names; otherwise the docs should be reverted/adjusted to describe `test-repo`.

## Fix Focus Areas
- docs/guides/dev/e2e-testing.md[74-103]
- docs/guides/infrastructure/mint-administration.md[73-76]
- pkg/behaviourtest/drivers/install/perrepo_github.go[17-88]
- docs/guides/dev/behaviour-testing.md[82-83]

Suggested resolution options (pick one and make all references consistent):
1) **Docs-only alignment (likely for this PR):** change behaviour enrollment guidance back to `halfsend-NN/test-repo` only, and remove/adjust the `test-repo-01..12` text + nested enroll loop.
2) **Implementation alignment:** make the behaviour driver choose `test-repo-${NN}` (configurable via env or lease index) and update inference provisioning + all docs accordingly.

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

2. e2e-testing.md outside admin/user 📜 Skill insight ⌂ Architecture

Description

Modified guide files were placed under docs/guides/dev/ and docs/guides/infrastructure/, but
guides are required to live under either docs/guides/admin/ or docs/guides/user/. This breaks
the mandated guide directory structure and audience split.

Code

docs/guides/dev/e2e-testing.md[R76-78]

+Behaviour tests install fullsend in **per-repo** mode (`fullsend github setup`). Triage workflows mint same-org `triage` tokens from vendored reusable workflows; that requires per-repo mint enrollment (`PER_REPO_WIF_REPOS`). The install driver does **not** run `mint enroll` — pool org behaviour repos must be enrolled once by a GCP admin on the hosted mint project.
+
+Admin e2e uses the singular `halfsend-NN/test-repo` name. Behaviour parallelization leases `halfsend-NN/test-repo-01` … `test-repo-12` (base names only — do **not** enroll `*-fork` names; forks are ephemeral PR sources and mint against the enrolled base repo). GitHub repositories need not exist yet — enroll is a mint allowlist / WIF-provider update only.

Relevance

⭐ Low

Similar “move guides out of docs/guides/dev” suggestion was rejected in PR #4901; dev/infrastructure
guides appear tolerated.

PR-#4901

ⓘ Recommendations generated based on similar findings in past PRs

Evidence

PR Compliance ID 1062077 requires every guide under docs/guides/ to be placed in admin/ or
user/. The changed content is located in docs/guides/dev/e2e-testing.md and
docs/guides/infrastructure/mint-administration.md, which are outside the required subdirectories,
and the guide placement rules are documented in docs/guides/README.md, together demonstrating the
directory placement violation.

docs/guides/dev/e2e-testing.md[76-78]
docs/guides/infrastructure/mint-administration.md[75-75]
Skill: writing-user-docs

Agent prompt

The issue below was found during a code review. Follow the provided context and guidance below and implement a solution

## Issue description
The modified guide files `docs/guides/dev/e2e-testing.md` and `docs/guides/infrastructure/mint-administration.md` are under `docs/guides/` but are not placed in an `admin/` or `user/` subdirectory as required by the guide taxonomy.

## Issue Context
PR Compliance ID 1062077 requires every guide under `docs/guides/` to be placed in `docs/guides/admin/` or `docs/guides/user/`. This PR modifies these guide files, so they must comply with the required guide directory structure and audience split as described in `docs/guides/README.md`.

## Fix Focus Areas
- docs/guides/dev/e2e-testing.md[76-78]
- docs/guides/infrastructure/mint-administration.md[75-75]
- docs/guides/README.md[44-52]
- docs/guides/README.md[21-30]

ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools

---

[fullsend-ai-review]

Looks good to me

Previous run

Review

Findings

Low

• [stale reference] docs/guides/dev/behaviour-drivers.md:34 — References only singular test-repo for per-repo mint enrollment. With this PR documenting that test-repo-01 through test-repo-12 also require enrollment, this cross-reference is now incomplete. The existing link to e2e-testing.md points to the updated enrollment section, mitigating the risk.

• [incomplete-prerequisite-documentation] docs/guides/dev/behaviour-testing.md:82 — States "Pool test-repo repos are enrolled once by a GCP admin" using singular form. Behaviour parallelization now requires enrolling test-repo-01 through test-repo-12 in addition to the singular test-repo. The existing cross-reference to e2e-testing.md links to the updated enrollment procedure.

• [internal consistency] docs/guides/dev/e2e-testing.md — The unchanged line about fullsend inference provision <org>/test-repo (singular) may become stale once behaviour parallelization code uses numbered repos, but is currently accurate for the existing install driver.

---

Labels: PR modifies e2e testing and mint enrollment documentation

[waynesun09]

LGTM overall — the runbook update and completed mint enrollment are a solid documentation of the ops prerequisite for #3454/#5437. Left one non-blocking inline comment: the "leases test-repo-01…test-repo-12" wording reads as current behavior but the consuming driver code isn't there yet (tracked in #3454/#5439). Approving since this is docs-only and the enrollment itself is genuinely done — just flagging for a quick wording pass.

[fullsend-ai-review]

🤖 Finished Review · ✅ Success · Started 1:41 PM UTC · Completed 1:54 PM UTC
Commit: 13d1fbe · View workflow run →

[fullsend-ai-retro]

🤖 Finished Retro · ✅ Success · Started 6:10 PM UTC · Completed 6:21 PM UTC
Commit: 13d1fbe · View workflow run →

[fullsend-ai-retro]

Retro: PR #5454 — docs(e2e): document behaviour pool mint enroll

Workflow shape: Human-authored docs-only PR. Triage agent ran on issue #5437 (run 29899673234). Review agent ran twice on the PR (runs 29908929589, 29924903322). No code or fix agents involved.

Timeline: PR opened 09:40 UTC → review agent approved with 3 Low findings + applied ready-for-merge at 09:56 → human rh-hemartin approved at 10:09 → human waynesun09 approved with substantive non-blocking feedback at 11:46 → author pushed fix commit at 13:39 → review agent re-approved at 13:54 → merged at 18:08.

Review quality gap: All three reviewers (qodo-code-review, fullsend-ai-review, waynesun09) noticed the docs/code mismatch around test-repo vs test-repo-01..12. However, the review agent framed it as Low-severity "stale references" in peripheral files. The human reviewer (waynesun09) correctly diagnosed the core issue: the primary changed file described planned parallelization in present tense as though it were current behavior. The human cited in-flight PR #5444 as evidence, identified a secondary issue with the *-fork exclusion being ahead of design (#5439 scope), and provided concrete replacement text. This led to a second commit.

No new proposals filed. All improvement opportunities are covered by existing open issues:

• Review agent should verify docs PRs reference features that exist in the codebase #2835 and Review correctness sub-agent should cross-reference verified facts to detect misleading documentation narratives agents#265: This PR provides fresh evidence that the review agent notices docs/code inconsistencies but fails to reason about temporal accuracy (present vs. future tense). The agent found the mismatch but framed it as a cross-reference gap rather than recognizing the docs were describing unimplemented functionality as current behavior.
• Review docs-currency sub-agent should cross-validate documentation examples against actual source files #5297: The docs-currency sub-agent's cross-validation gap applies here — the agent did not verify that the claimed leasing behavior exists in the codebase.
• Review agent should defer ready-for-merge label on documentation-only PRs until human review #1772: The review agent applied ready-for-merge at 09:56 UTC on a docs-only PR before any human had reviewed. The substantive human feedback at 11:46 UTC required a corrective commit, demonstrating the risk of premature labeling on docs PRs.
• Review agent should query for related open PRs before finalizing findings that reference files outside the PR diff agents#149: The human cross-referenced related PRs (refactor(#5438)!: per-scenario World in context + in-process repo lease pool #5444, ci(e2e): enable parallel godog behaviour scenarios #3454, feat(behaviour): lazy create+install on Given the enrolled test repository #5439) to validate claims, which the agent did not do.