ci(#5503): increase dispatch detection window to 4 minutes - #5506
Conversation
The behaviour test dispatch detection polling loop used dispatchMaxTry=24 × dispatchPoll=5s = 120s (2 minutes) to detect whether GitHub Actions dispatched a workflow in response to an issues event. When GitHub webhook delivery is under load, this 2-minute window is exceeded, causing false test failures that require human intervention to retry (observed on PRs #5497 and #5498 on the same day with unrelated code changes). Raise dispatchMaxTry from 24 to 48, extending the detection window to 48 × 5s = 240s (4 minutes). This stays well within the existing dispatchWait of 12 minutes for workflow completion. Add a regression test that asserts the dispatch detection window is at least 4 minutes. Note: pre-commit could not run (network 403 in sandbox). Manual linting verification is required. Closes #5503
Site previewPreview: https://424af7f4-site.fullsend-ai.workers.dev Commit: |
|
🤖 Finished Review · ✅ Success · Started 7:02 AM UTC · Completed 7:11 AM UTC |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Looks good to me Labels: PR modifies behaviour test e2e driver for GitHub Actions dispatch detection. |
|
🤖 Finished Retro · ✅ Success · Started 8:33 AM UTC · Completed 8:44 AM UTC |
|
Retro: PR #5506 — ci(#5503): increase dispatch detection window to 4 minutes This PR demonstrates an exemplary fully autonomous pipeline execution — from pattern detection to merged fix with zero rework. Timeline
What went well
Existing issues covering minor improvement areas
No new proposalsThis workflow executed cleanly across all stages. The code was correct on the first attempt, the review was internally thorough, and the fix was appropriate for the problem. The minor improvement areas identified are already tracked by existing open issues. |
Summary
dispatchMaxTryfrom 24 to 48 inpkg/behaviourtest/drivers/ci/githubactions/githubactions.goChanges
The only production change is the
dispatchMaxTryconstant:24→48. This extends the initial dispatch detection polling loop from 120s to 240s. The existingdispatchWait(12 minutes for workflow completion) is unchanged, so the new detection window is well within the overall timeout budget.A new test (
TestDispatchDetectionWindow_AtLeast4Minutes) validates thatdispatchMaxTry × dispatchPoll ≥ 4 minutes, preventing future regressions if someone lowers the constant.Testing
pkg/behaviourtest/drivers/ci/githubactions/pass, including the new regression testgo vetpassesCloses #5503
Post-script verification
agent/5503-increase-dispatch-timeout)481aab26ab5d62c1b026c22ff6b19b0012e41a23..HEAD)