Skip to content

docs(#5548): fix stale FULLSEND_DIR description in eval script - #5549

Merged
rh-hemartin merged 1 commit into
mainfrom
agent/5548-fix-fullsend-dir-comment
Jul 24, 2026
Merged

docs(#5548): fix stale FULLSEND_DIR description in eval script#5549
rh-hemartin merged 1 commit into
mainfrom
agent/5548-fix-fullsend-dir-comment

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Context

PR #5424 standardized the FULLSEND_DIR description across 11 files but missed eval/run-functional.sh. The review agent flagged the gap as a Low finding, which was approved past without a fix. This PR addresses that remaining occurrence.

Testing

  • Verified grep -r 'scaffold directory' eval/ returns no results
  • Verified both eval/run-functional.sh and eval/scripts/run-fullsend.sh now use consistent ".fullsend configuration directory" phrasing

Closes #5548

Post-script verification

  • Branch is not main/master (agent/5548-fix-fullsend-dir-comment)
  • Secret scan passed (gitleaks — 5e2089bf999d52dbab62fd034d0f76af8b8538d7..HEAD)
  • PR body secret scan passed (gitleaks — no-git)
  • Pre-commit hooks passed (authoritative run on runner)
  • Tests ran inside sandbox

Update the FULLSEND_DIR comment in eval/run-functional.sh from
"path to fullsend scaffold directory" to "path to the .fullsend
configuration directory" to match the phrasing established by
PR #5424 in eval/scripts/run-fullsend.sh and
docs/testing/functional-tests.md.

Note: pre-commit could not run (sandbox network restriction
blocked git fetch during hook initialization). The post-script
runs pre-commit authoritatively on the runner.

Closes #5548
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner July 23, 2026 20:41
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Triggers review agent dispatch label Jul 23, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Jul 23, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 8:43 PM UTC · Completed 8:50 PM UTC
Commit: 7549290 · View workflow run →

@github-actions

Copy link
Copy Markdown

Site preview

Preview: https://c270e010-site.fullsend-ai.workers.dev

Commit: 75492905383643167d9598b3b07799881ac0c7b2

@codecov

codecov Bot commented Jul 23, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me

@fullsend-ai-review fullsend-ai-review Bot added the ready-for-merge All reviewers approved — ready to merge label Jul 23, 2026
@rh-hemartin
rh-hemartin added this pull request to the merge queue Jul 24, 2026
Merged via the queue into main with commit c8a33f0 Jul 24, 2026
27 checks passed
@rh-hemartin
rh-hemartin deleted the agent/5548-fix-fullsend-dir-comment branch July 24, 2026 06:40
@fullsend-ai-retro

fullsend-ai-retro Bot commented Jul 24, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 6:43 AM UTC · Completed 6:55 AM UTC
Commit: 7549290 · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #5549 — docs(#5548): fix stale FULLSEND_DIR description in eval script

Verdict: Successful end-to-end automated workflow. No new proposals — all improvement opportunities map to existing open issues.

Timeline

This PR originated from the retro agent's analysis of PR #5424, which standardized FULLSEND_DIR descriptions across 11 files but missed eval/run-functional.sh. The retro agent filed issue #5548 with a clear problem statement, proposed fix, and validation criteria. The full pipeline then executed autonomously:

Time (UTC) Event
20:30 Retro agent files issue #5548 with ready-for-triage
20:32–20:35 Triage agent categorizes (Low/Documentation), applies ready-to-code (run)
20:36–20:41 Code agent makes 1-line fix, opens PR #5549 (run)
20:42–20:50 Review agent approves with "Looks good to me", applies ready-for-merge (run)
+10h (06:36) Human (rh-hemartin) approves
+10h (06:40) PR merged

Autonomous pipeline time: ~20 min (issue filed → PR reviewed and approved). Zero rework iterations. The code agent produced a correct fix on the first attempt.

What went well

  • Retro detection worked: The retro agent correctly identified a gap left by a prior PR and filed a well-scoped, actionable issue.
  • Pipeline coordination: Triage→Code→Review handoffs were clean, with no errors or retries.
  • Code quality: The code agent produced a single, correct commit that precisely matched the issue's proposed fix.
  • Review correctness: The review agent classified the change as "mechanical/value-only" and correctly approved.

Evidence for existing issues (no new proposals filed)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ready-for-merge All reviewers approved — ready to merge ready-for-review Triggers review agent dispatch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix stale FULLSEND_DIR description in eval/run-functional.sh missed by PR #5424

1 participant