docs(#5560): align suite-timeout authorization scope - #5561
Conversation
The suite-timeout policy added in PR #5527 used inconsistent authorization-source language: paragraph 1 accepted "an issue/PR comment" while paragraph 2 restricted to "the linked issue or PR description". These are distinct scopes in GitHub's data model. Align paragraph 2 to match paragraph 1's broader scope by changing "linked issue or PR description" to "linked issue or a PR comment". This preserves the original intent and is more practical since humans naturally authorize via comments. Closes #5560
|
🤖 Finished Review · ✅ Success · Started 7:13 AM UTC · Completed 7:27 AM UTC |
Site previewPreview: https://910c9aae-site.fullsend-ai.workers.dev Commit: |
|
🤖 Finished Retro · ✅ Success · Started 7:23 AM UTC · Completed 7:35 AM UTC |
|
Review skipped — this PR is already merged. The Posted by fullsend post-review check |
Retro: PR #5561 — docs(#5560): align suite-timeout authorization scopeWorkflow OverviewThis PR is the product of a fully automated retro→triage→code pipeline, with human involvement only at the approval/merge step. The chain started when the retro agent analyzed PR fullsend-ai/fullsend#5527 (which added a suite-timeout policy) and identified an unresolved qodo-code-review finding about inconsistent authorization-scope language between two paragraphs of the new policy. The retro agent filed issue fullsend-ai/fullsend#5560, the triage agent confirmed it as low-priority documentation ready-to-code, and the code agent produced a correct 1-line fix in PR #5561. Timeline
What Went Well
Known Inefficiencies (All Tracked by Existing Issues)Review agent race condition. The review agent took ~15 minutes for a 1-line docs change. The human approved and merged 7 minutes before the review completed. The agent correctly detected the merged state and skipped posting, but $2.78 of compute was consumed with no output. Three separate review runs were dispatched (PR opened, approval event, merge event). This pattern is well-tracked:
Disproportionate review effort for trivial changes. The review agent allocated its full sub-agent fleet (correctness, style-conventions, intent-coherence, docs-currency, plus Opus challenger) for a single-line documentation wording fix. Well-tracked:
Original review gap on PR #5527. The review agent on PR #5527 did not independently detect the authorization-scope inconsistency that qodo caught. This gap in internal-consistency detection for rule/guidance documents is tracked by #3901 and agents#265. AssessmentNo novel proposals. This was a well-functioning workflow demonstrating the retro agent's value in catching review findings that fell through the cracks. All identified inefficiencies are covered by existing open issues with good specificity. The main takeaway is a positive one: the retro→triage→code pipeline produced a correct fix autonomously in 11 minutes, and the only human involvement was a quick approval/merge. |
Summary
Align the authorization-source language in the suite-timeout policy so both paragraphs reference the same scope. Paragraph 2 previously said "linked issue or PR description" while paragraph 1 said "issue/PR comment" — these are distinct scopes in GitHub's data model. Updated paragraph 2 to say "linked issue or a PR comment" to match.
Related Issue
Fixes #5560
Changes
docs/contributing/go-code.md: changed "Explicit human authorization in the linked issue or PR description" to "Explicit human authorization in the linked issue or a PR comment" in the reviewer-facing paragraphTesting
Closes #5560
Post-script verification
agent/5560-fix-timeout-auth-scope)331d7498ce2dc4eae90a24883749e3d349fa1da9..HEAD)