Skip to content

docs(#5925): fix stale OTEL scoped-forwarding example in workflow-contracts.md - #5926

Merged
rh-hemartin merged 1 commit into
mainfrom
agent/5925-fix-stale-otel-example
Aug 5, 2026
Merged

docs(#5925): fix stale OTEL scoped-forwarding example in workflow-contracts.md#5926
rh-hemartin merged 1 commit into
mainfrom
agent/5925-fix-stale-otel-example

Conversation

@fullsend-ai-coder

Copy link
Copy Markdown
Contributor

Summary

Fixes a factually incorrect example in the normative "When reviewing PRs" section of docs/contributing/workflow-contracts.md. The parenthetical claimed OTEL_EXPORTER_OTLP_TRACES_HEADERS is "deliberately forwarded only to the triage job" — in reality, the secret is explicitly forwarded to every inline stage job in reusable-dispatch.yml (triage, code, review, fix, retro, prioritize, harness-run).

Changes

  • Updated the OTEL forwarding example to accurately state that the secret is forwarded to every inline stage job because each stage runs an agent that emits traces
  • Removed the misleading "scoped" qualifier from "explicit, scoped forwarding" since this particular secret is not an example of scoped forwarding

Testing

  • make lint-md-links passes — no broken links introduced
  • Verified the corrected description matches the actual env: blocks in reusable-dispatch.yml (OTEL secrets appear in all 7 inline stage jobs)
  • No test changes needed — TestOTELHeadersSecretThreading validates the actual secret threading in the workflow file, not the documentation text

Checklist

  • PR title follows Conventional Commits (correct type, ! for breaking changes)
  • Documentation-only change — no code or behavioral impact

Closes #5925

Post-script verification

  • Branch is not main/master (agent/5925-fix-stale-otel-example)
  • Secret scan passed (gitleaks — 19f058a97146a1b014192195afe41d247525e0f6..HEAD)
  • PR body secret scan passed (gitleaks — no-git)

…tracts.md

The "When reviewing PRs" section stated that
OTEL_EXPORTER_OTLP_TRACES_HEADERS is "deliberately forwarded
only to the triage job." This was factually incorrect — the
secret is forwarded to every inline stage job (triage, code,
review, fix, retro, prioritize, harness-run) because each
stage runs an agent that emits traces.

Update the parenthetical to accurately describe the current
forwarding behavior and remove the misleading "scoped" qualifier
since this secret is not an example of scoped forwarding.

Closes #5925
@fullsend-ai-coder
fullsend-ai-coder Bot requested a review from a team as a code owner August 5, 2026 10:00
@fullsend-ai-coder fullsend-ai-coder Bot added the ready-for-review Triggers review agent dispatch label Aug 5, 2026
@fullsend-ai-review

fullsend-ai-review Bot commented Aug 5, 2026

Copy link
Copy Markdown

🤖 Finished Review · ✅ Success · Started 10:01 AM UTC · Completed 10:11 AM UTC
Commit: 35e0534 · View workflow run →

@github-actions

github-actions Bot commented Aug 5, 2026

Copy link
Copy Markdown

Site preview

Preview: https://4bf28d63-site.fullsend-ai.workers.dev

Commit: 35e0534ace52a53769b9909793f67c1f82edb8e7

@codecov

codecov Bot commented Aug 5, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

@fullsend-ai-review

Copy link
Copy Markdown

Looks good to me


Labels: PR fixes documentation under docs/contributing/

@fullsend-ai-review fullsend-ai-review Bot added ready-for-merge All reviewers approved — ready to merge component/docs User-facing documentation labels Aug 5, 2026
@rh-hemartin
rh-hemartin added this pull request to the merge queue Aug 5, 2026
Merged via the queue into main with commit 5c5e5b7 Aug 5, 2026
31 checks passed
@rh-hemartin
rh-hemartin deleted the agent/5925-fix-stale-otel-example branch August 5, 2026 10:40
@fullsend-ai-retro

fullsend-ai-retro Bot commented Aug 5, 2026

Copy link
Copy Markdown

🤖 Finished Retro · ✅ Success · Started 10:42 AM UTC · Completed 10:53 AM UTC
Commit: 35e0534 · View workflow run →

@fullsend-ai-retro

Copy link
Copy Markdown

Retro: PR #5926 — docs fix for stale OTEL forwarding example

Timeline

This PR was the product of a fully autonomous retro→triage→code→review pipeline. The retro agent on PR #5887 identified that the review agent had correctly flagged a factually incorrect example in docs/contributing/workflow-contracts.md (claiming OTEL secrets are scoped to the triage job when they are forwarded to all 7 inline stage jobs), but the author merged #5887 without addressing the finding. The retro agent filed issue #5925 with a well-documented description.

The full pipeline executed cleanly:

Total: ~50 minutes, zero rework, single commit.

Assessment

This workflow went well. Key observations:

  1. Retro→code pipeline success story. The retro agent correctly escalated a valid review finding that was dismissed on the original PR. The code agent scoped the fix precisely (1 line changed in 1 file). The review agent correctly approved a straightforward factual correction. This is the system working as designed — review findings that get overridden by authors are surfaced as issues and resolved autonomously.

  2. Duplicate dispatches handled gracefully. GitHub delivered duplicate webhooks for both the issue creation and PR open events, resulting in extra fullsend.yaml runs. The downstream cancel-in-progress: true concurrency group on review.yml cancelled the duplicate review run within 1 second. This is extensively tracked by existing issues (feat: dispatch-layer dedup and per-issue concurrency guard to prevent duplicate agent runs #766, Deduplicate review dispatches for the same HEAD SHA #1452, Prioritize same-commit review dedup — PR #944 shows 10x waste on a single SHA #5139, Consolidate 22+ overlapping "skip retro/agent dispatch" issues into a single design issue #5817).

  3. Docs-only autonomy evidence. Both the agent and human approved this single-file docs correction without inline comments. The ~23 minute gap between agent approval (10:11) and human approval (10:34) was the primary latency contributor. This is additional evidence for existing tracking issues: agents#427 (docs-only PR competence), #4765 and #5289 (docs-only autonomy readiness). Per #5156, zero-comment human approval is not independently strong autonomy evidence, but it is consistent with the existing body of evidence for this change class.

Proposals

No new proposals. All potential improvements identified are already covered by existing open issues with active tracking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

component/docs User-facing documentation ready-for-merge All reviewers approved — ready to merge ready-for-review Triggers review agent dispatch

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix stale scoped-forwarding example in workflow-contracts.md

1 participant