docs(#5925): fix stale OTEL scoped-forwarding example in workflow-contracts.md - #5926
Conversation
…tracts.md The "When reviewing PRs" section stated that OTEL_EXPORTER_OTLP_TRACES_HEADERS is "deliberately forwarded only to the triage job." This was factually incorrect — the secret is forwarded to every inline stage job (triage, code, review, fix, retro, prioritize, harness-run) because each stage runs an agent that emits traces. Update the parenthetical to accurately describe the current forwarding behavior and remove the misleading "scoped" qualifier since this secret is not an example of scoped forwarding. Closes #5925
|
🤖 Finished Review · ✅ Success · Started 10:01 AM UTC · Completed 10:11 AM UTC |
Site previewPreview: https://4bf28d63-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Looks good to me Labels: PR fixes documentation under docs/contributing/ |
|
🤖 Finished Retro · ✅ Success · Started 10:42 AM UTC · Completed 10:53 AM UTC |
Retro: PR #5926 — docs fix for stale OTEL forwarding exampleTimelineThis PR was the product of a fully autonomous retro→triage→code→review pipeline. The retro agent on PR #5887 identified that the review agent had correctly flagged a factually incorrect example in The full pipeline executed cleanly:
Total: ~50 minutes, zero rework, single commit. AssessmentThis workflow went well. Key observations:
ProposalsNo new proposals. All potential improvements identified are already covered by existing open issues with active tracking. |
Summary
Fixes a factually incorrect example in the normative "When reviewing PRs" section of
docs/contributing/workflow-contracts.md. The parenthetical claimedOTEL_EXPORTER_OTLP_TRACES_HEADERSis "deliberately forwarded only to thetriagejob" — in reality, the secret is explicitly forwarded to every inline stage job inreusable-dispatch.yml(triage, code, review, fix, retro, prioritize, harness-run).Changes
Testing
make lint-md-linkspasses — no broken links introducedenv:blocks inreusable-dispatch.yml(OTEL secrets appear in all 7 inline stage jobs)TestOTELHeadersSecretThreadingvalidates the actual secret threading in the workflow file, not the documentation textChecklist
!for breaking changes)Closes #5925
Post-script verification
agent/5925-fix-stale-otel-example)19f058a97146a1b014192195afe41d247525e0f6..HEAD)