docs(#5952): remove stale customized/ directory references - #5955
Conversation
|
🤖 Finished Review · ✅ Success · Started 7:59 PM UTC · Completed 8:19 PM UTC |
Site previewPreview: https://98755610-site.fullsend-ai.workers.dev Commit: |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
|
Looks good to me Previous runReviewFindingsMedium
Low
Previous run (2)ReviewFindingsLow
Labels: PR modifies only documentation files under docs/ |
282ce4a to
57fcd76
Compare
|
🤖 Finished Review · ✅ Success · Started 9:26 PM UTC · Completed 9:42 PM UTC Commit: |
Signed-off-by: Claude <noreply@anthropic.com> Signed-off-by: Greg Allen <gallen@redhat.com>
57fcd76 to
597ecc1
Compare
|
🤖 Finished Review · ✅ Success · Started 9:46 PM UTC · Completed 10:01 PM UTC Commit: |
|
🤖 Finished Retro · ✅ Success · Started 11:36 PM UTC · Completed 11:51 PM UTC Commit: |
Retro: PR #5955 — Remove stale customized/ directory referencesThis docs-only PR followed a clean workflow: issue #5952 (filed by ggallen with detailed per-file instructions) -> triage (3 min) -> code agent (11 min, 17 files changed) -> review -> human fix -> re-review -> merge. The code agent produced comprehensive coverage across all locations listed in the issue. Timeline
Key finding: orphaned setup stepThe code agent removed the The issue's verification command ( Evidence for existing issues (no new proposals needed)
Review quality noteThe first review (Aug 5, agents@ |
Summary
Remove all stale
customized/directory references from user-facing documentation. Thecustomized/overlay mechanism (ADR-0064) was fully removed by PRs #5697, #5836, and #5866 — this PR completes the cleanup by updating ~13 doc locations across 11 files to point users tobase:composition and config-driven agent registration instead.Related Issue
Closes #5952
Changes
High priority — guide rewrites:
customizing-agents.md: Replaced the deprecated "Layered Configuration Resolution" section with a concise "base:Composition" section; removedcustomized/paths from harness intro, skill/agent/harness override examples, and pre-commit tool resolution docsbuilding-custom-agents.md: Updated all file paths from.fullsend/customized/to.fullsend/, removed the overlay workflow step from the GHA example, updated file checklist to includeconfig.yamlMedium priority — actionable instruction fixes:
triage.md,review.md: Replacedcustomized/skills/paths with config-driven registration referencesarchitecture.md: Rewrote the "Decided" section to describe the current agent configuration modelruntimes.md: Simplified Layer 3 diagram to removecustomized/skills/linesrunning-agents-locally.md: Replacedcp -r customized/steps with config-driven workflowcustomizing-with-skills.md: Rewrote "Overriding built-in skills" section to usebase:compositionLow priority — cross-reference fixes:
default-vs-custom.md,customizing-with-agents-md.md,cli-internals.md,tier-conventions.md,gitlab-cron-polling-implementation.md,guides/README.md,bring-your-own-agent.md: Updated link text, table entries, and minor referencesTesting
customized/references remain in user-facing docs (excluding ADRs, plans, and glossary)scan-secretspassed on all changed filesgitlintpassed on commit messageChecklist
!for breaking changes)Closes #5952
Post-script verification
agent/5952-remove-customized-dir-refs)ad9b3ced5c978656450d716a9e7dbab071401cf0..HEAD)